rosedu/wouso

View on GitHub

Showing 2,707 of 2,707 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            self.fields['correct_%d' % i] = forms.BooleanField(required=False, initial=a.correct)
Severity: Major
Found in wouso/interface/cpanel/forms.py and 3 other locations - About 30 mins to fix
wouso/interface/cpanel/forms.py on lines 141..141
wouso/interface/cpanel/forms.py on lines 144..144
wouso/interface/cpanel/forms.py on lines 145..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            self.fields['active_%d' % i] = forms.BooleanField(required=False, initial=a.active)
Severity: Major
Found in wouso/interface/cpanel/forms.py and 3 other locations - About 30 mins to fix
wouso/interface/cpanel/forms.py on lines 140..140
wouso/interface/cpanel/forms.py on lines 144..144
wouso/interface/cpanel/forms.py on lines 145..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

class RacesEdit(UpdateView):
    model = Race
    template_name = 'cpanel/races/edit_race.html'
    form_class = RaceForm

Severity: Major
Found in wouso/interface/cpanel/views.py and 3 other locations - About 30 mins to fix
wouso/interface/cpanel/views.py on lines 1024..1030
wouso/interface/cpanel/views.py on lines 1042..1048
wouso/interface/cpanel/views.py on lines 1050..1055

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return "%s %s %s" % (self.type, self.user_from, self.spell)
Severity: Major
Found in wouso/core/magic/models.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return False, 'Something wrong'
    Severity: Major
    Found in wouso/core/god/god.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return redirect('challenge_index_view')
      Severity: Major
      Found in wouso/games/challenge/views.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return render_to_response('workshop/play.html',
        Severity: Major
        Found in wouso/games/workshop/views.py - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            $.fn.popover.noConflict = function () {
              $.fn.popover = old
              return this
            }
          Severity: Minor
          Found in wouso/resources/static/js/bootstrap.js and 1 other location - About 30 mins to fix
          wouso/resources/static/js/bootstrap.js on lines 1552..1555

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                  return redirect('challenge_index_view')
          Severity: Major
          Found in wouso/games/challenge/views.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return {'success': False, 'error': 'Cannot refuse this challenge'}
            Severity: Major
            Found in wouso/games/challenge/api.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return False, 'Player is cursed'
              Severity: Major
              Found in wouso/core/god/god.py - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  $.fn.tooltip.noConflict = function () {
                    $.fn.tooltip = old
                    return this
                  }
                Severity: Minor
                Found in wouso/resources/static/js/bootstrap.js and 1 other location - About 30 mins to fix
                wouso/resources/static/js/bootstrap.js on lines 1666..1669

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                class GroupsEdit(CreateView):
                    model = PlayerGroup
                    template_name = 'cpanel/races/group_edit.html'
                    form_class = PlayerGroupForm
                    def get_success_url(self):
                Severity: Major
                Found in wouso/interface/cpanel/views.py and 3 other locations - About 30 mins to fix
                wouso/interface/cpanel/views.py on lines 1024..1030
                wouso/interface/cpanel/views.py on lines 1033..1039
                wouso/interface/cpanel/views.py on lines 1042..1048

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                            return redirect('challenge_index_view')
                Severity: Major
                Found in wouso/games/challenge/views.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return {'success': False, 'error': 'Unknown action'}
                  Severity: Major
                  Found in wouso/games/challenge/api.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return False
                    Severity: Major
                    Found in wouso/games/quest/models.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return False, 'Something wrong'
                      Severity: Major
                      Found in wouso/core/god/god.py - About 30 mins to fix

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                self.fields['active'] = forms.BooleanField(required=False, initial=instance.active if instance else False)
                        Severity: Minor
                        Found in wouso/interface/cpanel/forms.py and 2 other locations - About 30 mins to fix
                        wouso/interface/cpanel/forms.py on lines 158..158
                        wouso/interface/apps/lesson/forms.py on lines 76..76

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 32.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Avoid too many return statements within this function.
                        Open

                                        return {'success': True}
                        Severity: Major
                        Found in wouso/games/challenge/api.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return {'success': False, 'error': 'Cannot accept this challenge'}
                          Severity: Major
                          Found in wouso/games/challenge/api.py - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language