Sign upLogin

rosedu/wouso

View on GitHub
Star

Showing 2,707 of 2,707 total issues

Avoid too many return statements within this function.
Open

        return True, None
Severity: Major
Found in wouso/core/god/god.py - About 30 mins to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            self.fields['active'] = forms.BooleanField(required=False, initial=instance.active if instance else False)
    Severity: Minor
    Found in wouso/interface/cpanel/forms.py and 2 other locations - About 30 mins to fix
    wouso/interface/cpanel/forms.py on lines 45..45
    wouso/interface/apps/lesson/forms.py on lines 76..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    class RacesAdd(CreateView):
    model = Race
    template_name = 'cpanel/races/create.html'
    form_class = RaceForm
    Severity: Major
    Found in wouso/interface/cpanel/views.py and 3 other locations - About 30 mins to fix
    wouso/interface/cpanel/views.py on lines 1033..1039
    wouso/interface/cpanel/views.py on lines 1042..1048
    wouso/interface/cpanel/views.py on lines 1050..1055

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

                    return {'success': False, 'error': 'Cannot cancel this challenge'}
    Severity: Major
    Found in wouso/games/challenge/api.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return {'success': True, 'result': result}
      Severity: Major
      Found in wouso/games/challenge/api.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return False, 'Player is cursed'
        Severity: Major
        Found in wouso/core/god/god.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return False, None, None
          Severity: Major
          Found in wouso/core/security/sec.py - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        self.fields['rich_active_%d' % i] = forms.BooleanField(required=False, initial=a.active)
            Severity: Major
            Found in wouso/interface/cpanel/forms.py and 3 other locations - About 30 mins to fix
            wouso/interface/cpanel/forms.py on lines 140..140
            wouso/interface/cpanel/forms.py on lines 141..141
            wouso/interface/cpanel/forms.py on lines 144..144

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            class GroupsAdd(CreateView):
    model = PlayerGroup
    template_name = 'cpanel/races/group_create.html'
    form_class = PlayerGroupForm
            Severity: Major
            Found in wouso/interface/cpanel/views.py and 3 other locations - About 30 mins to fix
            wouso/interface/cpanel/views.py on lines 1024..1030
            wouso/interface/cpanel/views.py on lines 1033..1039
            wouso/interface/cpanel/views.py on lines 1050..1055

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                        return answer.strip().lower() in answers
            Severity: Major
            Found in wouso/games/quest/models.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return False, 'Player already has this spell cast on him'
              Severity: Major
              Found in wouso/core/god/god.py - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def setUp(self):
        Challenge.LIMIT = 0
        Challenge.WARRANTY = False
        super(GrandChallengeTest, self).setUp()
                Severity: Minor
                Found in wouso/games/grandchallenge/tests.py and 1 other location - About 30 mins to fix
                wouso/games/grandchallenge/tests.py on lines 73..76

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                class AddNewsView(CreateView):
    template_name = "cpanel/add_news.html"
    model = NewsItem
    form_class = NewsForm
                Severity: Minor
                Found in wouso/interface/cpanel/views.py and 1 other location - About 30 mins to fix
                wouso/interface/cpanel/views.py on lines 1083..1089

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                class RoleAdd(CreateView):
    template_name = 'cpanel/roles_add.html'
    model = Group
    form_class = RoleForm
                Severity: Minor
                Found in wouso/interface/cpanel/views.py and 1 other location - About 30 mins to fix
                wouso/interface/cpanel/views.py on lines 1223..1229

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if request.method != 'POST':
        form = AuthenticationForm(request)
        return render_to_response('registration/login.html', {'form': form, 'next': next},
            context_instance=RequestContext(request))
                Severity: Minor
                Found in wouso/interface/views.py and 1 other location - About 30 mins to fix
                wouso/games/grandchallenge/cpanel_views.py on lines 44..48

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                @staff_required
def grandchalls_round_results(request, round_number):
    round = Round(round_number)
    return render_to_response('grandchallenge/cpanel/grandchallenge_round_results.html', {'round': round, 'gc': GrandChallengeGame},
                              context_instance=RequestContext(request))
                Severity: Minor
                Found in wouso/games/grandchallenge/cpanel_views.py and 1 other location - About 30 mins to fix
                wouso/interface/views.py on lines 46..49

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def setUp(self):
        Challenge.LIMIT = 0
        Challenge.WARRANTY = False
        super(GCUserTest, self).setUp()
                Severity: Minor
                Found in wouso/games/grandchallenge/tests.py and 1 other location - About 30 mins to fix
                wouso/games/grandchallenge/tests.py on lines 11..14

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function forum_actions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def forum_actions(request):
    action = request.GET.get('action', None)
    f_id = request.GET.get('f_id', '').split()
    f_id = map(int, f_id)
    queryset = Forum.objects.filter(id__in=f_id)
                Severity: Minor
                Found in wouso/interface/forum/cpanel_views.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function pyramid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def pyramid(request):
    s = []
    for r in Race.objects.exclude(can_play=False).order_by('name'):
        columns = []
        players = []
                Severity: Minor
                Found in wouso/interface/top/views.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function qpool_export has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def qpool_export(request, cat):
    category = get_object_or_404(Category, name=cat)
    response = HttpResponse(mimetype='text/txt')
    response[
        'Content-Disposition'] = 'attachment; filename=question_%s_export.txt' % slugify(
                Severity: Minor
                Found in wouso/interface/cpanel/views.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language