Sign upLogin

rqueensen/faludi-lca-app

View on GitHub
Star
app/controllers/users_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method signup has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

   def signup
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
Severity: Minor
Found in app/controllers/users_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method signup has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

   def signup
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
Severity: Minor
Found in app/controllers/users_controller.rb - About 1 hr to fix

    Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

       def login
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status