rueian/rueidis

View on GitHub

Showing 637 of 651 total issues

Method sentinelClient._switchTarget has 6 return statements (exceeds 4 allowed).
Open

func (c *sentinelClient) _switchTarget(addr string) (err error) {
    var target conn
    if atomic.LoadUint32(&c.stop) == 1 {
        return nil
    }
Severity: Major
Found in sentinel.go - About 40 mins to fix

    Function NewBloomFilter has 6 return statements (exceeds 4 allowed).
    Open

    func NewBloomFilter(
        client rueidis.Client,
        name string,
        expectedNumberOfItems uint,
        falsePositiveRate float64,
    Severity: Major
    Found in rueidisprob/bloomfilter.go - About 40 mins to fix

      Function NewClient has 6 return statements (exceeds 4 allowed).
      Open

      func NewClient(option ClientOption) (client Client, err error) {
          if option.ReadBufferEachConn < 32 { // the buffer should be able to hold an int64 string at least
              option.ReadBufferEachConn = DefaultReadBuffer
          }
          if option.WriteBufferEachConn < 32 {
      Severity: Major
      Found in rueidis.go - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (mr *ClientMockRecorder) Dedicated(arg0 any) *gomock.Call {
            mr.mock.ctrl.T.Helper()
            return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Dedicated", reflect.TypeOf((*Client)(nil).Dedicated), arg0)
        }
        Severity: Minor
        Found in mock/client.go and 1 other location - About 40 mins to fix
        mock/client.go on lines 331..334

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (mr *DedicatedClientMockRecorder) SetPubSubHooks(arg0 any) *gomock.Call {
            mr.mock.ctrl.T.Helper()
            return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "SetPubSubHooks", reflect.TypeOf((*DedicatedClient)(nil).SetPubSubHooks), arg0)
        }
        Severity: Minor
        Found in mock/client.go and 1 other location - About 40 mins to fix
        mock/client.go on lines 99..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function newMux has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func newMux(dst string, option *ClientOption, init, dead wire, wireFn wireFn, wireNoBgFn wireFn) *mux {
        Severity: Minor
        Found in mux.go - About 35 mins to fix

          Function startSpan has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func startSpan(tracer trace.Tracer, ctx context.Context, op string, size int, attrs trace.SpanStartEventOption) (context.Context, trace.Span) {
          Severity: Minor
          Found in rueidisotel/trace.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case "message":
                    if len(values) >= 3 {
                        m := PubSubMessage{Channel: values[1].string, Message: values[2].string}
                        p.nsubs.Publish(values[1].string, m)
                        p.pshks.Load().(*pshks).hooks.OnMessage(m)
            Severity: Minor
            Found in pipe.go and 1 other location - About 35 mins to fix
            pipe.go on lines 662..667

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case "smessage":
                    if len(values) >= 3 {
                        m := PubSubMessage{Channel: values[1].string, Message: values[2].string}
                        p.ssubs.Publish(values[1].string, m)
                        p.pshks.Load().(*pshks).hooks.OnMessage(m)
            Severity: Minor
            Found in pipe.go and 1 other location - About 35 mins to fix
            pipe.go on lines 650..655

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c ZunionWeights) Weights(weight ...int64) ZunionWeights {
                c.cs.s = append(c.cs.s, "WEIGHTS")
                for _, n := range weight {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_sorted_set.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 732..738
            internal/cmds/gen_sorted_set.go on lines 946..952
            internal/cmds/gen_sorted_set.go on lines 2546..2552
            internal/cmds/gen_timeseries.go on lines 2063..2069
            internal/cmds/gen_timeseries.go on lines 2975..2981
            internal/cmds/gen_timeseries.go on lines 3894..3900
            internal/cmds/gen_timeseries.go on lines 4574..4580

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c TsRangeFilterByTs) FilterByTs(timestamp ...int64) TsRangeFilterByTs {
                c.cs.s = append(c.cs.s, "FILTER_BY_TS")
                for _, n := range timestamp {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_timeseries.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 732..738
            internal/cmds/gen_sorted_set.go on lines 946..952
            internal/cmds/gen_sorted_set.go on lines 2396..2402
            internal/cmds/gen_sorted_set.go on lines 2546..2552
            internal/cmds/gen_timeseries.go on lines 2063..2069
            internal/cmds/gen_timeseries.go on lines 2975..2981
            internal/cmds/gen_timeseries.go on lines 4574..4580

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c ZinterWeights) Weights(weight ...int64) ZinterWeights {
                c.cs.s = append(c.cs.s, "WEIGHTS")
                for _, n := range weight {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_sorted_set.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 946..952
            internal/cmds/gen_sorted_set.go on lines 2396..2402
            internal/cmds/gen_sorted_set.go on lines 2546..2552
            internal/cmds/gen_timeseries.go on lines 2063..2069
            internal/cmds/gen_timeseries.go on lines 2975..2981
            internal/cmds/gen_timeseries.go on lines 3894..3900
            internal/cmds/gen_timeseries.go on lines 4574..4580

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c TsMrevrangeFilterByTs) FilterByTs(timestamp ...int64) TsMrevrangeFilterByTs {
                c.cs.s = append(c.cs.s, "FILTER_BY_TS")
                for _, n := range timestamp {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_timeseries.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 732..738
            internal/cmds/gen_sorted_set.go on lines 946..952
            internal/cmds/gen_sorted_set.go on lines 2396..2402
            internal/cmds/gen_sorted_set.go on lines 2546..2552
            internal/cmds/gen_timeseries.go on lines 2063..2069
            internal/cmds/gen_timeseries.go on lines 3894..3900
            internal/cmds/gen_timeseries.go on lines 4574..4580

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c TsRevrangeFilterByTs) FilterByTs(timestamp ...int64) TsRevrangeFilterByTs {
                c.cs.s = append(c.cs.s, "FILTER_BY_TS")
                for _, n := range timestamp {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_timeseries.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 732..738
            internal/cmds/gen_sorted_set.go on lines 946..952
            internal/cmds/gen_sorted_set.go on lines 2396..2402
            internal/cmds/gen_sorted_set.go on lines 2546..2552
            internal/cmds/gen_timeseries.go on lines 2063..2069
            internal/cmds/gen_timeseries.go on lines 2975..2981
            internal/cmds/gen_timeseries.go on lines 3894..3900

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c ZinterstoreWeights) Weights(weight ...int64) ZinterstoreWeights {
                c.cs.s = append(c.cs.s, "WEIGHTS")
                for _, n := range weight {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_sorted_set.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 732..738
            internal/cmds/gen_sorted_set.go on lines 2396..2402
            internal/cmds/gen_sorted_set.go on lines 2546..2552
            internal/cmds/gen_timeseries.go on lines 2063..2069
            internal/cmds/gen_timeseries.go on lines 2975..2981
            internal/cmds/gen_timeseries.go on lines 3894..3900
            internal/cmds/gen_timeseries.go on lines 4574..4580

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c ZunionstoreWeights) Weights(weight ...int64) ZunionstoreWeights {
                c.cs.s = append(c.cs.s, "WEIGHTS")
                for _, n := range weight {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_sorted_set.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 732..738
            internal/cmds/gen_sorted_set.go on lines 946..952
            internal/cmds/gen_sorted_set.go on lines 2396..2402
            internal/cmds/gen_timeseries.go on lines 2063..2069
            internal/cmds/gen_timeseries.go on lines 2975..2981
            internal/cmds/gen_timeseries.go on lines 3894..3900
            internal/cmds/gen_timeseries.go on lines 4574..4580

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

            func (c TsMrangeFilterByTs) FilterByTs(timestamp ...int64) TsMrangeFilterByTs {
                c.cs.s = append(c.cs.s, "FILTER_BY_TS")
                for _, n := range timestamp {
                    c.cs.s = append(c.cs.s, strconv.FormatInt(n, 10))
                }
            Severity: Major
            Found in internal/cmds/gen_timeseries.go and 7 other locations - About 35 mins to fix
            internal/cmds/gen_sorted_set.go on lines 732..738
            internal/cmds/gen_sorted_set.go on lines 946..952
            internal/cmds/gen_sorted_set.go on lines 2396..2402
            internal/cmds/gen_sorted_set.go on lines 2546..2552
            internal/cmds/gen_timeseries.go on lines 2975..2981
            internal/cmds/gen_timeseries.go on lines 3894..3900
            internal/cmds/gen_timeseries.go on lines 4574..4580

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method bloomFilter.ExistsMulti has 5 return statements (exceeds 4 allowed).
            Open

            func (c *bloomFilter) ExistsMulti(ctx context.Context, keys []string) ([]bool, error) {
                if len(keys) == 0 {
                    return nil, nil
                }
            
            
            Severity: Major
            Found in rueidisprob/bloomfilter.go - About 35 mins to fix

              Method locker.waitgate has 5 return statements (exceeds 4 allowed).
              Open

              func (m *locker) waitgate(ctx context.Context, name string) (g *gate, err error) {
                  m.mu.Lock()
                  g, ok := m.gates[name]
                  if !ok {
                      if m.gates == nil {
              Severity: Major
              Found in rueidislock/lock.go - About 35 mins to fix

                Method RedisMessage.AsZScores has 5 return statements (exceeds 4 allowed).
                Open

                func (m *RedisMessage) AsZScores() ([]ZScore, error) {
                    arr, err := m.ToArray()
                    if err != nil {
                        return nil, err
                    }
                Severity: Major
                Found in message.go - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language