Sign upLogin

rueian/rueidis

View on GitHub
Star
message.go

Summary

Maintainability
D
2 days
Test Coverage
A
100%

File message.go has 1146 lines of code (exceeds 500 allowed). Consider refactoring.
Wontfix

package rueidis

import (
    "encoding/json"
    "fmt"
Severity: Major
Found in message.go - About 2 days to fix

    RedisMessage has 50 methods (exceeds 20 allowed). Consider refactoring.
    Wontfix

    type RedisMessage struct {
    attrs   *RedisMessage
    string  string
    values  []RedisMessage
    integer int64
    Severity: Minor
    Found in message.go - About 7 hrs to fix

      RedisResult has 41 methods (exceeds 20 allowed). Consider refactoring.
      Wontfix

      type RedisResult struct {
    err error
    val RedisMessage
}
      Severity: Minor
      Found in message.go - About 5 hrs to fix

        Method RedisMessage.AsFtSearch has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
        Open

        func (m *RedisMessage) AsFtSearch() (total int64, docs []FtSearchDoc, err error) {
    if err = m.Error(); err != nil {
        return 0, nil, err
    }
    if m.IsMap() {
        Severity: Minor
        Found in message.go - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method RedisMessage.AsFtSearch has 69 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (m *RedisMessage) AsFtSearch() (total int64, docs []FtSearchDoc, err error) {
    if err = m.Error(); err != nil {
        return 0, nil, err
    }
    if m.IsMap() {
        Severity: Minor
        Found in message.go - About 1 hr to fix

          Method RedisMessage.AsFtAggregate has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
          Open

          func (m *RedisMessage) AsFtAggregate() (total int64, docs []map[string]string, err error) {
    if err = m.Error(); err != nil {
        return 0, nil, err
    }
    if m.IsMap() {
          Severity: Minor
          Found in message.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method RedisMessage.AsGeosearch has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
          Open

          func (m *RedisMessage) AsGeosearch() ([]GeoLocation, error) {
    arr, err := m.ToArray()
    if err != nil {
        return nil, err
    }
          Severity: Minor
          Found in message.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  switch record.values[j].string {
                        case "extra_attributes":
                            docs[d], _ = record.values[j+1].AsStrMap()
                        }
          Severity: Major
          Found in message.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            } else if v.typ == typeInteger || v.typ == typeNull {
                    r[k.string] = v.integer
                }
            Severity: Major
            Found in message.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if r[k.string], err = strconv.ParseInt(v.string, 0, 64); err != nil {
                        return nil, err
                    }
              Severity: Major
              Found in message.go - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        switch record.values[j].string {
                        case "id":
                            docs[d].Key = record.values[j+1].string
                        case "extra_attributes":
                            docs[d].Doc, _ = record.values[j+1].AsStrMap()
                Severity: Major
                Found in message.go - About 45 mins to fix

                  Method RedisMessage.AsXRangeEntry has 6 return statements (exceeds 4 allowed).
                  Open

                  func (m *RedisMessage) AsXRangeEntry() (XRangeEntry, error) {
    values, err := m.ToArray()
    if err != nil {
        return XRangeEntry{}, err
    }
                  Severity: Major
                  Found in message.go - About 40 mins to fix

                    Method RedisMessage.AsXRead has 6 return statements (exceeds 4 allowed).
                    Open

                    func (m *RedisMessage) AsXRead() (ret map[string][]XRangeEntry, err error) {
    if err = m.Error(); err != nil {
        return nil, err
    }
    if m.IsMap() {
                    Severity: Major
                    Found in message.go - About 40 mins to fix

                      Method RedisMessage.AsZScores has 5 return statements (exceeds 4 allowed).
                      Open

                      func (m *RedisMessage) AsZScores() ([]ZScore, error) {
    arr, err := m.ToArray()
    if err != nil {
        return nil, err
    }
                      Severity: Major
                      Found in message.go - About 35 mins to fix

                        Method RedisMessage.AsIntMap has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (m *RedisMessage) AsIntMap() (map[string]int64, error) {
    if err := m.Error(); err != nil {
        return nil, err
    }
    if (m.IsMap() || m.IsArray()) && len(m.values)%2 == 0 {
                        Severity: Minor
                        Found in message.go - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func (m *RedisMessage) AsLMPop() (kvs KeyValues, err error) {
    if err = m.Error(); err != nil {
        return KeyValues{}, err
    }
    if len(m.values) >= 2 {
                        Severity: Major
                        Found in message.go and 1 other location - About 1 hr to fix
                        message.go on lines 1013..1024

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 154.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func (m *RedisMessage) AsZMPop() (kvs KeyZScores, err error) {
    if err = m.Error(); err != nil {
        return KeyZScores{}, err
    }
    if len(m.values) >= 2 {
                        Severity: Major
                        Found in message.go and 1 other location - About 1 hr to fix
                        message.go on lines 995..1006

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 154.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status