Sign upLogin

rugk/threema-msgapi-sdk-php

View on GitHub
Star

Showing 299 of 299 total issues

Avoid using static access to class '\Threema\Console\Common' in method 'testGetPrivateKey'.
Open

        $realPrivateKey = Common::getPrivateKey(Constants::myPrivateKey);
Severity: Minor
Found in source/Threema/MsgApi/Tests/CommonTests.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'testDerivePublicKey'.
Open

            $myPublicKey = $cryptTool->hex2bin(Common::getPublicKey(Constants::myPublicKey));
Severity: Minor
Found in source/Threema/MsgApi/Tests/CryptToolTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'testEncryptImage'.
Open

            $otherPrivateKey = $cryptTool->hex2bin(Common::getPrivateKey(Constants::otherPrivateKey));
Severity: Minor
Found in source/Threema/MsgApi/Tests/CryptToolTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Salt' in method 'encryptImageData'.
Open

        $message = Salt::decodeInput($imageData);
Severity: Minor
Found in source/Threema/MsgApi/Tools/CryptToolSalt.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Sodium' in method 'makeBox'.
Open

        $kp = Sodium::crypto_box_keypair_from_secretkey_and_publickey($senderPrivateKey, $recipientPublicKey);
Severity: Minor
Found in source/Threema/MsgApi/Tools/CryptToolSodiumDep.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Constant argPhoneNo should be defined in uppercase
Open

    const argPhoneNo = 'phoneNo';
Severity: Minor
Found in source/Threema/Console/Command/LookupIdByPhoneNo.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argSecret should be defined in uppercase
Open

    const argSecret = 'secret';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argImageFile should be defined in uppercase
Open

    const argImageFile = 'imageFile';
Severity: Minor
Found in source/Threema/Console/Command/SendE2EImage.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argPrivateKeyFile should be defined in uppercase
Open

    const argPrivateKeyFile = 'privateKeyFile';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argEmail should be defined in uppercase
Open

    const argEmail = 'email';
Severity: Minor
Found in source/Threema/Console/Command/HashEmail.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argFile should be defined in uppercase
Open

    const argFile = 'file';
Severity: Minor
Found in source/Threema/Console/Command/SendE2EFile.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argPrivateKey should be defined in uppercase
Open

    const argPrivateKey = 'privateKey';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argPublicKey should be defined in uppercase
Open

    const argPublicKey = 'publicKey';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argPublicKeyFile should be defined in uppercase
Open

    const argPublicKeyFile = 'publicKeyFile';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argEmail should be defined in uppercase
Open

    const argEmail = 'email';
Severity: Minor
Found in source/Threema/Console/Command/LookupIdByEmail.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argThreemaId should be defined in uppercase
Open

    const argThreemaId = 'threemaId';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argOutputFolder should be defined in uppercase
Open

    const argOutputFolder = 'outputFolder';
Severity: Minor
Found in source/Threema/Console/Command/ReceiveMessage.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argThumbnail should be defined in uppercase
Open

    const argThumbnail = 'thumbnailFile';
Severity: Minor
Found in source/Threema/Console/Command/SendE2EFile.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant myPrivateKeyExtract should be defined in uppercase
Open

    const myPrivateKeyExtract = '94af3260fa2a19adc8e82e82be598be15bc6ad6f47c8ee303cb185ef860e16d2';
Severity: Minor
Found in source/Threema/MsgApi/Tests/Constants.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argFrom should be defined in uppercase
Open

    const argFrom = 'from';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Severity
Category
Status
Source
Language