Sign upLogin

rugk/threema-msgapi-sdk-php

View on GitHub
Star

Showing 299 of 299 total issues

The method receiveMessage() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
Open

    public final function receiveMessage($threemaId,
                                         $messageId,
                                         $box,
                                         $nonce,
                                         $outputFolder = null,
Severity: Minor
Found in source/Threema/MsgApi/Helpers/E2EHelper.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Constant argPublicKey should be defined in uppercase
Open

    const argPublicKey = 'publicKey';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant otherPrivateKey should be defined in uppercase
Open

    const otherPrivateKey = 'private:8318e05220acd38e97ba41a9a6318688214219916075ca060f9339a6d1f7fc29';
Severity: Minor
Found in source/Threema/MsgApi/Tests/Constants.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argImageFile should be defined in uppercase
Open

    const argImageFile = 'imageFile';
Severity: Minor
Found in source/Threema/Console/Command/SendE2EImage.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argPhoneNo should be defined in uppercase
Open

    const argPhoneNo = 'phoneNo';
Severity: Minor
Found in source/Threema/Console/Command/HashPhone.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant echochoPublicKey should be defined in uppercase
Open

    const echochoPublicKey = 'public:4a6a1b34dcef15d43cb74de2fd36091be99fbbaf126d099d47d83d919712c72b';
Severity: Minor
Found in source/Threema/MsgApi/Tests/Constants.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

The method decryptMessage() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
Open

    final public function decryptMessage($box, $recipientPrivateKey, $senderPublicKey, $nonce) {

        $data = $this->openBox($box, $recipientPrivateKey, $senderPublicKey, $nonce);

        if (null === $data || strlen($data) == 0) {
Severity: Minor
Found in source/Threema/MsgApi/Tools/CryptTool.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Constant argThumbnail should be defined in uppercase
Open

    const argThumbnail = 'thumbnailFile';
Severity: Minor
Found in source/Threema/Console/Command/SendE2EFile.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argThreemaId should be defined in uppercase
Open

    const argThreemaId = 'threemaId';
Severity: Minor
Found in source/Threema/Console/Command/Base.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant argEmail should be defined in uppercase
Open

    const argEmail = 'email';
Severity: Minor
Found in source/Threema/Console/Command/LookupIdByEmail.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant myPrivateKey should be defined in uppercase
Open

    const myPrivateKey = 'private:94af3260fa2a19adc8e82e82be598be15bc6ad6f47c8ee303cb185ef860e16d2';
Severity: Minor
Found in source/Threema/MsgApi/Tests/Constants.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

The method createDefaultOptions() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
Open

    private function createDefaultOptions(\Closure $progress = null) {
        $options = array(
            CURLOPT_RETURNTRANSFER => true
        );
Severity: Minor
Found in source/Threema/MsgApi/Connection.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Constant tlsOptionCipher should be defined in uppercase
Open

    const tlsOptionCipher = 'tlsCipher';
Severity: Minor
Found in source/Threema/MsgApi/ConnectionSettings.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant myPrivateKeyExtract should be defined in uppercase
Open

    const myPrivateKeyExtract = '94af3260fa2a19adc8e82e82be598be15bc6ad6f47c8ee303cb185ef860e16d2';
Severity: Minor
Found in source/Threema/MsgApi/Tests/Constants.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant otherPublicKey should be defined in uppercase
Open

    const otherPublicKey = 'public:10ac7fd937eafb806f9a05bf9afa340a99387b0063cc9cb0d1ea5505d39cc076';
Severity: Minor
Found in source/Threema/MsgApi/Tests/Constants.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant tlsOptionVersion should be defined in uppercase
Open

    const tlsOptionVersion = 'tlsVersion';
Severity: Minor
Found in source/Threema/MsgApi/ConnectionSettings.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant randomNonce should be defined in uppercase
Open

    const randomNonce = '516f4f1562dda0704a7bae8997cf0b354c6980181152ac32';
Severity: Minor
Found in source/Threema/MsgApi/Tests/Constants.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

The variable $STDERR is not named in camelCase.
Open

    public static function e($msg) {
        $STDERR = fopen('php://stderr', 'w+');
        fwrite($STDERR, $msg."\n");

    }
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $STDERR is not named in camelCase.
Open

    public static function e($msg) {
        $STDERR = fopen('php://stderr', 'w+');
        fwrite($STDERR, $msg."\n");

    }
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

Severity
Category
Status
Source
Language