Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star

Showing 597 of 597 total issues

Avoid using static access to class 'ThreemaGateway_Handler_Permissions' in method '__construct'.
Open

        $this->permissions = ThreemaGateway_Handler_Permissions::getInstance();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Abstract.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'ThreemaGateway_Handler_PhpSdk' in method 'getSdk'.
Open

            $this->sdk = ThreemaGateway_Handler_PhpSdk::getInstance($this->settings);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Abstract.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XenForo_Application' in method 'validateRequest'.
Open

        $options = XenForo_Application::getOptions();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Callback.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XenForo_Error' in method 'processMessage'.
Open

            XenForo_Error::logException($e);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Callback.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XenForo_Application' in method 'checkForDeliveryReceipt'.
Open

        $class       = XenForo_Application::resolveDynamicClass('ThreemaGateway_Handler_Action_TfaCallback_DeliveryReceipt');
Severity: Minor
Found in src/library/ThreemaGateway/Listener/TfaMessageCallback.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'ThreemaGateway_Handler_PhpSdk' in method 'checkPhpSdk'.
Open

            $sdk = ThreemaGateway_Handler_PhpSdk::getInstance($gwSettings);
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'ThreemaGateway_Helper_Random' in method 'generateDefault'.
Open

        return ThreemaGateway_Helper_Random::getRandomAlphaNum(self::ACCESS_TOKEN_LENGTH);
Severity: Minor
Found in src/library/ThreemaGateway/Option/ReceiveCallback.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'ThreemaGateway_Helper_General' in method 'renderOption'.
Open

            $preparedOption['option_value'] = ThreemaGateway_Helper_General::censorString($preparedOption['option_value'], self::CHARS_LEAVE_UNCENSORED);
Severity: Minor
Found in src/library/ThreemaGateway/Option/ThreemaGatewaySecret.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$providerData'.
Open

    protected function preSaveDataMerged(array $confirmRequest, array &$providerData, array $processOptions = [])
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$confirmRequest'.
Open

    protected function postSaveData(array $confirmRequest, array &$providerData, array $processOptions = [])
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$data'.
Open

    public static function addHelpers(XenForo_Dependencies_Abstract $dependencies, array $data)
Severity: Minor
Found in src/library/ThreemaGateway/Listener/InitDependencies.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$tableName'.
Open

    protected function _getUpdateCondition($tableName)
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$threemaMsg'.
Open

                                        Threema\MsgApi\Messages\ThreemaMessage $threemaMsg,
Severity: Minor
Found in docs/examples/MessageCallback.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method _getFields() has 124 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    protected function _getFields()
    {
        return [
            ThreemaGateway_Model_Messages::DB_TABLE_MESSAGES => [
                'message_id' => [
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php by phpmd

Avoid unused parameters such as '$tableName'.
Open

    protected function _getUpdateCondition($tableName)
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/TfaPendingMessagesConfirmation.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$debugMode'.
Open

                                        $debugMode)
Severity: Minor
Found in docs/examples/MessageCallback.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class 'XenForo_Application' in method 'renderOption'.
Open

        if (!XenForo_Application::debugMode() && !$preparedOption['option_value']['enabled']) {
Severity: Minor
Found in src/library/ThreemaGateway/Option/DebugModeLog.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XenForo_Application' in method 'moveDir'.
Open

        $xenOptions = XenForo_Application::getOptions();
Severity: Minor
Found in src/library/ThreemaGateway/Option/DownloadPath.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'ThreemaGateway_Handler_Validation' in method 'moveDir'.
Open

        if (!ThreemaGateway_Handler_Validation::checkDir($orgDir)) {
Severity: Minor
Found in src/library/ThreemaGateway/Option/DownloadPath.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XenForo_Application' in method 'renderHtml'.
Open

            if (XenForo_Application::debugMode()) {
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language