rugk/xenforo-threema-gateway

The method groupArray has a boolean flag argument $ignoreIndex, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function groupArray(array $array, $indexKey, $ignoreIndex = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method roundToDay has a boolean flag argument $roundUp, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function roundToDay($time, $roundUp = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '106', column '33').

Open

            $keyConverter = new ThreemaGateway_Handler_Action_KeyConverter;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '225', column '23').

Open

            throw new XenForo_Exception('Download dir ' . $downloadPath . ' cannot be accessed.');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid too many return statements within this method.

Open

            return false;

Missing class import via use statement (line '34', column '23').

Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_threema_id_does_not_exist') . ' ' . $e->getMessage());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '45', column '36').

Open

            $dataWriter->error(new XenForo_Phrase('threemagw_invalid_discard_old_date'), $fieldName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '277', column '23').

Open

            throw new XenForo_Exception('Message could not be saved: [' . get_class($e) . '] ' . $e->getMessage());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid too many return statements within this method.

Open

            return false;

Missing class import via use statement (line '406', column '23').

Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_database_data'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '434', column '45').

Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_unknown_message_type'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '29', column '37').

Open

        $gatewayHandlerServer = new ThreemaGateway_Handler_Action_GatewayServer;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '152', column '23').

Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_libsodium_error'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '45', column '36').

Open

            $dataWriter->error(new XenForo_Phrase('threemagw_invalid_downloadpath'), $fieldName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '233', column '46').

Open

            $status['credits']['text'] = new XenForo_Phrase('option_threema_gateway_status_credits', ['credits' => $credits]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '244', column '51').

Open

            $status['credits']['descr']     = new XenForo_Phrase('option_threema_gateway_status_credits_low');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '73', column '36').

Open

            $dataWriter->error(new XenForo_Phrase('threemagw_invalid_threema_secret'), $fieldName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '90', column '23').

Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '108', column '57').

Open

                $status['libsodium']['descr']     = new XenForo_Phrase('option_threema_gateway_status_libsodium_outdated');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '215', column '46').

Open

        $status['credits']['addition'] = new XenForo_Phrase('option_threema_gateway_status_credits_recharge');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}