Sign upLogin

rwbutler/Updates

View on GitHub
Star
Updates/Classes/UI/UpdatesUI.swift

Summary

Maintainability
D
1 day
Test Coverage

Function promptToUpdate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static func promptToUpdate(
        _ result: UpdatesResult,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
Severity: Minor
Found in Updates/Classes/UI/UpdatesUI.swift - About 1 hr to fix

    Function promptToUpdate has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static func promptToUpdate(
        newVersionString: String?,
        appStoreId: String?,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
    Severity: Minor
    Found in Updates/Classes/UI/UpdatesUI.swift - About 1 hr to fix

      Function promptToUpdate has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              newVersionString: String?,
        appStoreId: String?,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
      Severity: Major
      Found in Updates/Classes/UI/UpdatesUI.swift - About 1 hr to fix

        Function promptToUpdate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static func promptToUpdate(
        _ result: UpdatesResult,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
        Severity: Minor
        Found in Updates/Classes/UI/UpdatesUI.swift - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function promptToUpdate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static func promptToUpdate(
        newVersionString: String?,
        appStoreId: String?,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        Severity: Minor
        Found in Updates/Classes/UI/UpdatesUI.swift - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function promptToUpdate has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                _ result: UpdatesResult,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
        title: String? = nil,
        Severity: Minor
        Found in Updates/Classes/UI/UpdatesUI.swift - About 45 mins to fix

          Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController
          Severity: Minor
          Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

            Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        delegate: SKStoreProductViewControllerDelegate,
        presentingViewController: UIViewController
            Severity: Minor
            Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

              Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       completion: (() -> Void)? = nil,
                                       presentingViewController: UIViewController) {
              Severity: Minor
              Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

                Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       delegate: SKStoreProductViewControllerDelegate,
                                       presentingViewController: UIViewController) {
                Severity: Minor
                Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public func presentAppStore(
        animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        completion: (() -> Void)? = nil,
                  Severity: Minor
                  Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
                  Updates/Classes/UI/UpdatesUI.swift on lines 195..207

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       completion: (() -> Void)? = nil,
                                       presentingViewController: UIViewController) {
                  Severity: Minor
                  Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
                  Updates/Classes/UI/UpdatesUI.swift on lines 35..62

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 55.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          viewController.loadProduct(withParameters: parameters) { [weak self] (loadedSuccessfully, _) in
            if !loadedSuccessfully, let appStoreURL = appStoreURL {
                self?.presentSafariViewController(
                    animated: animated,
                    presentingViewController: presentingViewController,
                  Severity: Minor
                  Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
                  Updates/Classes/UI/UpdatesUI.swift on lines 80..86

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 53.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          viewController.loadProduct(withParameters: parameters) { [weak self] (loadedSuccessfully, _) in
            if !loadedSuccessfully, let appStoreURL = appStoreURL {
                self?.presentSafariViewController(animated: animated,
                                                  presentingViewController: presentingViewController,
                                                  url: appStoreURL)
                  Severity: Minor
                  Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
                  Updates/Classes/UI/UpdatesUI.swift on lines 50..58

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 53.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public func presentAppStore(
        animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        delegate: SKStoreProductViewControllerDelegate,
                  Severity: Minor
                  Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 35 mins to fix
                  Updates/Classes/UI/UpdatesUI.swift on lines 214..226

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       delegate: SKStoreProductViewControllerDelegate,
                                       presentingViewController: UIViewController) {
                  Severity: Minor
                  Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 35 mins to fix
                  Updates/Classes/UI/UpdatesUI.swift on lines 65..90

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status