Sign upLogin

rwbutler/Updates

View on GitHub
Star

Showing 41 of 41 total issues

VersionComparisonTests has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class VersionComparisonTests: XCTestCase {

    // MARK: - Major Numbers
    
    func testMajorComparatorEqualityWhereMajorNumbersEqual() {
Severity: Minor
Found in Example/Tests/VersionComparisonTests.swift - About 2 hrs to fix

    Function manufacture has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func manufacture() -> UpdatesResult {
        guard let bundleVersion = configuration.bundleVersion else {
            return .none(
                AppUpdatedResult(isFirstLaunchFollowingInstall: false, isFirstLaunchFollowingUpdate: false)
            )
    Severity: Major
    Found in Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift - About 2 hrs to fix

      Function compareVersions has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          static func compareVersions(
        lhs: String,
        lhsBuildNumber: String? = nil,
        rhs: String,
        rhsBuildNumber: String? = nil,
      Severity: Minor
      Found in Updates/Classes/Core/Updates+Internal.swift - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compareVersions has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static func compareVersions(
        lhs: String,
        lhsBuildNumber: String? = nil,
        rhs: String,
        rhsBuildNumber: String? = nil,
      Severity: Minor
      Found in Updates/Classes/Core/Updates+Internal.swift - About 1 hr to fix

        Function promptToUpdate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static func promptToUpdate(
        _ result: UpdatesResult,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
        Severity: Minor
        Found in Updates/Classes/UI/UpdatesUI.swift - About 1 hr to fix

          Function promptToUpdate has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static func promptToUpdate(
        newVersionString: String?,
        appStoreId: String?,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
          Severity: Minor
          Found in Updates/Classes/UI/UpdatesUI.swift - About 1 hr to fix

            Function registerBuild has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                func registerBuild(versionString: String, buildString: String?, comparator: VersionComparator) ->
        AppUpdatedResult {
        let buildString = buildString ?? "0"
        guard var versionInformation = cachedVersionInfo() else {
            postAppDidInstallNotification()
            Severity: Minor
            Found in Updates/Classes/Services/Version/Implementation/DefaultVersionJournalingService.swift - About 1 hr to fix

              Function checkForUpdates has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  func checkForUpdates(completion: @escaping (UpdatesResult) -> Void) {
        DispatchQueue.global(qos: .background).async {
            self.appMetadataService.fetchAppMetadata { result in
                switch result {
                case .success(let apiResult):
              Severity: Minor
              Found in Updates/Classes/Services/Updates/AutomaticUpdateResolutionService.swift - About 1 hr to fix

                Function manufacture has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    func manufacture() -> UpdatesResult {
        guard let bundleVersion = configuration.bundleVersion else {
            return .none(
                AppUpdatedResult(isFirstLaunchFollowingInstall: false, isFirstLaunchFollowingUpdate: false)
            )
                Severity: Minor
                Found in Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function checkForUpdates has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    func checkForUpdates(completion: @escaping (UpdatesResult) -> Void) {
        let updatesService: UpdateResolutionService
        switch strategy {
        case .automatically:
            if let appMetadataService = appMetadataService {
                Severity: Minor
                Found in Updates/Classes/Services/Updates/StrategicUpdatesService.swift - About 1 hr to fix

                  Function minVersionRequirement has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private func minVersionRequirement(
        minAppVersion: String,
        bundleVersion: String,
        configuration: ConfigurationResult,
        updateType: UpdateType
                  Severity: Minor
                  Found in Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift - About 1 hr to fix

                    Function promptToUpdate has 8 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            newVersionString: String?,
        appStoreId: String?,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
                    Severity: Major
                    Found in Updates/Classes/UI/UpdatesUI.swift - About 1 hr to fix

                      Function encode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                          func encode(to encoder: Encoder) throws {
        var container = encoder.container(keyedBy: CodingKeys.self)
        try container.encode(appStoreId, forKey: .appStoreId)
        try container.encode(buildString, forKey: .build)
        try container.encode(bundleVersion, forKey: .bundleVersion)
                      Severity: Minor
                      Found in Updates/Classes/Services/App Metadata/Model/ConfigurationResult.swift - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function promptToUpdate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public static func promptToUpdate(
        _ result: UpdatesResult,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
                      Severity: Minor
                      Found in Updates/Classes/UI/UpdatesUI.swift - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function promptToUpdate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public static func promptToUpdate(
        newVersionString: String?,
        appStoreId: String?,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
                      Severity: Minor
                      Found in Updates/Classes/UI/UpdatesUI.swift - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              guard let json = try? JSONSerialization.jsonObject(with: data, options: .allowFragments),
            let jsonContainer = json as? [String: Any],
            let results = jsonContainer["results"],
            let resultsData = try? JSONSerialization.data(withJSONObject: results) else {
                if let result = (try? decoder.decode([ITunesSearchAPIResult].self, from: data))?.first {
                      Severity: Minor
                      Found in Updates/Classes/Services/App Metadata/Implementation/ITunesSearchJSONParsingService.swift and 1 other location - About 50 mins to fix
                      Updates/Classes/Services/Parsing/Implementation/ConfigurationJSONParsingService.swift on lines 13..22

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 60.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              guard let json = try? JSONSerialization.jsonObject(with: data, options: .allowFragments),
            let jsonContainer = json as? [String: Any],
            let results = jsonContainer["updates"],
            let resultsData = try? JSONSerialization.data(withJSONObject: results) else {
                if let result = try? decoder.decode(ConfigurationResult.self, from: data) {
                      Severity: Minor
                      Found in Updates/Classes/Services/Parsing/Implementation/ConfigurationJSONParsingService.swift and 1 other location - About 50 mins to fix
                      Updates/Classes/Services/App Metadata/Implementation/ITunesSearchJSONParsingService.swift on lines 20..29

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 60.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function promptToUpdate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              _ result: UpdatesResult,
        animated: Bool = true,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController,
        title: String? = nil,
                      Severity: Minor
                      Found in Updates/Classes/UI/UpdatesUI.swift - About 45 mins to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public func presentAppStore(
        animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        completion: (() -> Void)? = nil,
                        Severity: Minor
                        Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
                        Updates/Classes/UI/UpdatesUI.swift on lines 195..207

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 55.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       completion: (() -> Void)? = nil,
                                       presentingViewController: UIViewController) {
                        Severity: Minor
                        Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
                        Updates/Classes/UI/UpdatesUI.swift on lines 35..62

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 55.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language