Sign upLogin

rwbutler/Updates

View on GitHub
Star

Showing 41 of 41 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        viewController.loadProduct(withParameters: parameters) { [weak self] (loadedSuccessfully, _) in
            if !loadedSuccessfully, let appStoreURL = appStoreURL {
                self?.presentSafariViewController(
                    animated: animated,
                    presentingViewController: presentingViewController,
Severity: Minor
Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
Updates/Classes/UI/UpdatesUI.swift on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        viewController.loadProduct(withParameters: parameters) { [weak self] (loadedSuccessfully, _) in
            if !loadedSuccessfully, let appStoreURL = appStoreURL {
                self?.presentSafariViewController(animated: animated,
                                                  presentingViewController: presentingViewController,
                                                  url: appStoreURL)
Severity: Minor
Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 45 mins to fix
Updates/Classes/UI/UpdatesUI.swift on lines 50..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function compareVersions has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        lhs: String,
        lhsBuildNumber: String? = nil,
        rhs: String,
        rhsBuildNumber: String? = nil,
        comparator: VersionComparator
Severity: Minor
Found in Updates/Classes/Core/Updates+Internal.swift - About 35 mins to fix

    Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        completion: (() -> Void)? = nil,
        presentingViewController: UIViewController
    Severity: Minor
    Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

      Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        delegate: SKStoreProductViewControllerDelegate,
        presentingViewController: UIViewController
      Severity: Minor
      Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

        Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       completion: (() -> Void)? = nil,
                                       presentingViewController: UIViewController) {
        Severity: Minor
        Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

          Function presentAppStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       delegate: SKStoreProductViewControllerDelegate,
                                       presentingViewController: UIViewController) {
          Severity: Minor
          Found in Updates/Classes/UI/UpdatesUI.swift - About 35 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                func testBuildComparatorEqualityWhereComponentsEqual() {
        let result = Updates.compareVersions(
            lhs: "1.2.3",
            lhsBuildNumber: "4",
            rhs: "1.2.3",
            Severity: Minor
            Found in Example/Tests/VersionComparisonTests.swift and 2 other locations - About 35 mins to fix
            Example/Tests/VersionComparisonTests.swift on lines 129..138
            Example/Tests/VersionComparisonTests.swift on lines 140..149

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function fetchSettings has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private func fetchSettings(configurationURL: URL, defaults: ConfigurationResult) -> ConfigurationServiceResult {
        guard let configurationData = try? Data(contentsOf: configurationURL) else {
            return .failure(.networking)
        }
        let parsingResult = parsingService.parse(configurationData)
            Severity: Minor
            Found in Updates/Classes/Services/Configuration/Implementation/DefaultConfigurationService.swift - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                func testBuildComparatorEqualityWhereComponentsAscending() {
        let result = Updates.compareVersions(
            lhs: "1.2.3",
            lhsBuildNumber: "4",
            rhs: "1.2.3",
            Severity: Minor
            Found in Example/Tests/VersionComparisonTests.swift and 2 other locations - About 35 mins to fix
            Example/Tests/VersionComparisonTests.swift on lines 118..127
            Example/Tests/VersionComparisonTests.swift on lines 140..149

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                func testBuildComparatorEqualityWhereComponentsDescending() {
        let result = Updates.compareVersions(
            lhs: "1.2.3",
            lhsBuildNumber: "5",
            rhs: "1.2.3",
            Severity: Minor
            Found in Example/Tests/VersionComparisonTests.swift and 2 other locations - About 35 mins to fix
            Example/Tests/VersionComparisonTests.swift on lines 118..127
            Example/Tests/VersionComparisonTests.swift on lines 129..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function checkForUpdates has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                func checkForUpdates(completion: @escaping (UpdatesResult) -> Void) {
        DispatchQueue.global(qos: .background).async {
            self.appMetadataService.fetchAppMetadata { result in
                switch result {
                case .success(let apiResult):
            Severity: Minor
            Found in Updates/Classes/Services/Updates/AutomaticUpdateResolutionService.swift - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public func presentAppStore(
        animated: Bool = true,
        appStoreId: String?,
        appStoreURL: URL?,
        delegate: SKStoreProductViewControllerDelegate,
            Severity: Minor
            Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 35 mins to fix
            Updates/Classes/UI/UpdatesUI.swift on lines 214..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 44.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public static func presentAppStore(animated: Bool = true,
                                       appStoreId: String?,
                                       appStoreURL: URL?,
                                       delegate: SKStoreProductViewControllerDelegate,
                                       presentingViewController: UIViewController) {
            Severity: Minor
            Found in Updates/Classes/UI/UpdatesUI.swift and 1 other location - About 35 mins to fix
            Updates/Classes/UI/UpdatesUI.swift on lines 65..90

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 44.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                init(
        configuration: ConfigurationResult,
        journalingService: VersionJournalingService,
        operatingSystemVersion: String
    ) {
            Severity: Minor
            Found in Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift and 1 other location - About 30 mins to fix
            Updates/Classes/Services/Updates/ManualUpdateResolutionService.swift on lines 16..24

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                init(
        configuration: ConfigurationResult,
        journalingService: VersionJournalingService,
        operatingSystemVersion: String
    ) {
            Severity: Minor
            Found in Updates/Classes/Services/Updates/ManualUpdateResolutionService.swift and 1 other location - About 30 mins to fix
            Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift on lines 23..31

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                    return .success(result)
            Severity: Major
            Found in Updates/Classes/Services/App Metadata/Implementation/ITunesSearchJSONParsingService.swift - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if let minRequiredAppVersion = configuration.minRequiredAppVersion {
            if let minVersionUpdateAvailable = minVersionRequirement(
                minAppVersion: minRequiredAppVersion,
                bundleVersion: bundleVersion,
                configuration: configuration,
              Severity: Minor
              Found in Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift and 1 other location - About 30 mins to fix
              Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift on lines 49..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if let minOptionalAppVersion = configuration.minOptionalAppVersion {
            if let minVersionUpdateAvailable = minVersionRequirement(
                minAppVersion: minOptionalAppVersion,
                bundleVersion: bundleVersion,
                configuration: configuration,
              Severity: Minor
              Found in Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift and 1 other location - About 30 mins to fix
              Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift on lines 39..48

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                      return willNotify ? .available(update) : .none(isAppUpdated)
              Severity: Major
              Found in Updates/Classes/Services/App Metadata/Model/UpdatesResultFactory.swift - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language