Sign upLogin

sambauers/capistrano-committed

View on GitHub
Star
lib/capistrano/committed/github_api.rb

Summary

Maintainability
A
0 mins
Test Coverage
C
73%

Method has too many lines. [14/10]
Open

      def register_deployment_status(user, repo, id, state)
        validate_user_and_repo(user, repo, __callee__)
        validate('id', id, Integer, __callee__)

        valid_states = %w[pending success error failure]
Severity: Minor
Found in lib/capistrano/committed/github_api.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

      def register_deployment(user, repo, stage, branch = 'master')
        validate_user_and_repo(user, repo, __callee__)
        validate('stage', stage, String, __callee__)
        validate('branch', branch, String, __callee__)
Severity: Minor
Found in lib/capistrano/committed/github_api.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

      def get_pull_request(user, repo, number)
        validate_user_and_repo(user, repo, __callee__)
        validate('number', number, Integer, __callee__)

        api_call do
Severity: Minor
Found in lib/capistrano/committed/github_api.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Missing magic comment # frozen_string_literal: true.
Open

require 'github_api'
Severity: Minor
Found in lib/capistrano/committed/github_api.rb by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

There are no issues that match your filters.

Category
Status