Sign upLogin

scottohara/loot

View on GitHub
Star

Showing 298 of 298 total issues

Function getTransactions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public getTransactions(
        direction: TransactionFetchDirection,
        fromDate?: Date,
        transactionIdToFocus?: number,
    ): void {
Severity: Minor
Found in src/transactions/controllers/index.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Possible SQL injection
Open

                "transaction_headers.transaction_date #{LEDGER_QUERY_OPTS[opts[:direction]][:order]}",
Severity: Minor
Found in app/models/concerns/transactable.rb by brakeman

Injection is #1 on the 2013 OWASP Top Ten web security risks. SQL injection is when a user is able to manipulate a value which is used unsafely inside a SQL query. This can lead to data leaks, data loss, elevation of privilege, and other unpleasant outcomes.

Brakeman focuses on ActiveRecord methods dealing with building SQL statements.

A basic (Rails 2.x) example looks like this:

User.first(:conditions => "username = '#{params[:username]}'")

Brakeman would produce a warning like this:

Possible SQL injection near line 30: User.first(:conditions => ("username = '#{params[:username]}'"))

The safe way to do this query is to use a parameterized query:

User.first(:conditions => ["username = ?", params[:username]])

Brakeman also understands the new Rails 3.x way of doing things (and local variables and concatenation):

username = params[:user][:name].downcase
password = params[:user][:password]

User.first.where("username = '" + username + "' AND password = '" + password + "'")

This results in this kind of warning:

Possible SQL injection near line 37:
User.first.where((((("username = '" + params[:user][:name].downcase) + "' AND password = '") + params[:user][:password]) + "'"))

See the Ruby Security Guide for more information and Rails-SQLi.org for many examples of SQL injection in Rails.

Function save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public save(
        schedule: ScheduledTransaction,
    ): angular.IPromise<ScheduledTransaction> {
        // If the payee, category, subcategory or security are new; flush the $http cache
        if ("string" === typeof (schedule as PayeeCashTransaction).payee) {
Severity: Minor
Found in src/schedules/models/schedule.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public constructor(
        private readonly $uibModal: UibModalMock = {
            open(options: angular.ui.bootstrap.IModalSettings): {
                result: UibModalMockResult;
            } {
Severity: Minor
Found in src/mocks/node-modules/angular/services/uibmodal.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateLruCaches has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private updateLruCaches(
        transaction: Transaction,
    ): angular.IPromise<Transaction> {
        // Create a deferred so that we return a promise
        const q: angular.IDeferred<Transaction> = this.$q.defer();
Severity: Minor
Found in src/transactions/controllers/edit.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Expected (<color>) but found 'var(--state-success-text)'.</color>
Open

        color: var(--state-success-text);
Severity: Minor
Found in src/transactions/css/flag.css by csslint

@import prevents parallel downloads, use <link> instead.
Open

@import "~/loot/css/variables.css";
Severity: Minor
Found in src/transactions/css/flag.css by csslint

Expected (<color>) but found 'var(--state-warning-text)'.</color>
Open

        color: var(--state-warning-text);
Severity: Minor
Found in src/transactions/css/flag.css by csslint

Adjoining classes: .has-action i.action.active
Open

.has-action i.action.active {
Severity: Minor
Found in src/transactions/css/flag.css by csslint

Rule is empty.
Open

#transactions,
Severity: Minor
Found in src/transactions/css/index.css by csslint

Unexpected token '&' at line 13, col 2.
Open

    &.taxdeductible {
Severity: Minor
Found in src/transactions/css/flag.css by csslint

Fallback background-color (hex or RGB) should precede RGBA background-color.
Open

            background-color: rgba(0, 255, 0, 0.1);
Severity: Minor
Found in src/transactions/css/index.css by csslint

Unexpected token '&' at line 35, col 3.
Open

        &.transaction-date {
Severity: Minor
Found in src/transactions/css/index.css by csslint

Rule is empty.
Open

strong,
Severity: Minor
Found in src/transactions/css/flag.css by csslint

Unexpected token '&' at line 9, col 2.
Open

    &.noreceipt {
Severity: Minor
Found in src/transactions/css/flag.css by csslint

Don't use IDs in selectors.
Open

#transactions,
Severity: Minor
Found in src/transactions/css/index.css by csslint

Element (tr.future) is overqualified, just use .future without element name.
Open

    tr:not(.future) + tr.future {
Severity: Minor
Found in src/transactions/css/index.css by csslint

Expected RBRACE at line 31, col 3.
Open

        &.has-dropdown {
Severity: Minor
Found in src/transactions/css/index.css by csslint

@import prevents parallel downloads, use <link> instead.
Open

@import "~/loot/css/variables.css";
Severity: Minor
Found in src/transactions/css/index.css by csslint

Don't use IDs in selectors.
Open

#transactions-header {
Severity: Minor
Found in src/transactions/css/index.css by csslint
Severity
Category
Status
Source
Language