Sign upLogin

seanedwards/cfer

View on GitHub
Star
lib/cfer/cfn/client.rb

Summary

Maintainability
D
2 days
Test Coverage

Method tail has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def tail(options = {})
      q = []
      event_id_highwater = nil
      counter = 0
      number = options[:number] || 0
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method converge has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def converge(stack, options = {})
      Preconditions.check(@name).is_not_nil
      Preconditions.check(stack) { is_not_nil and has_type(Cfer::Core::Stack) }

      template_options = upload_or_return_template(stack.to_cfn, options)
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Client has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client < Cfer::Core::Client
    attr_reader :name
    attr_reader :stack

    def initialize(options)
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 2 hrs to fix

Method converge has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def converge(stack, options = {})
      Preconditions.check(@name).is_not_nil
      Preconditions.check(stack) { is_not_nil and has_type(Cfer::Core::Stack) }

      template_options = upload_or_return_template(stack.to_cfn, options)
Severity: Major
Found in lib/cfer/cfn/client.rb - About 2 hrs to fix

File client.rb has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative '../core/client'
require 'uri'

module Cfer::Cfn
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 2 hrs to fix

Method tail has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def tail(options = {})
      q = []
      event_id_highwater = nil
      counter = 0
      number = options[:number] || 0
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 1 hr to fix

Method parse_stack_policy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_stack_policy(name, value)
      Cfer::LOGGER.debug "Using #{name} from: #{value}"
      if value.nil?
        {}
      elsif value.is_a?(Hash)
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method estimate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def estimate(stack, options = {})
      estimate_options = upload_or_return_template(stack.to_cfn, options)
      response = validate_template(estimate_options)

      estimate_params = []
Severity: Minor
Found in lib/cfer/cfn/client.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status