Sign upLogin

secureCodeBox/secureCodeBox

View on GitHub
Star
auto-discovery/kubernetes/controllers/service_scan_controller.go

Summary

Maintainability
C
1 day
Test Coverage

Method ServiceScanReconciler.Reconcile has 140 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *ServiceScanReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
    log := r.Log

    log.V(8).Info("Something happened to a service", "service", req.Name, "namespace", req.Namespace)
Severity: Major
Found in auto-discovery/kubernetes/controllers/service_scan_controller.go - About 4 hrs to fix

    Method ServiceScanReconciler.Reconcile has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
    Open

    func (r *ServiceScanReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
    log := r.Log

    log.V(8).Info("Something happened to a service", "service", req.Name, "namespace", req.Namespace)
    Severity: Minor
    Found in auto-discovery/kubernetes/controllers/service_scan_controller.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if port.Port == 80 ||
            port.Port == 8080 ||
            port.Port == 443 ||
            port.Port == 8443 ||
            // Node.js
    Severity: Critical
    Found in auto-discovery/kubernetes/controllers/service_scan_controller.go - About 1 hr to fix

      Method ServiceScanReconciler.Reconcile has 10 return statements (exceeds 4 allowed).
      Open

      func (r *ServiceScanReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
    log := r.Log

    log.V(8).Info("Something happened to a service", "service", req.Name, "namespace", req.Namespace)
      Severity: Major
      Found in auto-discovery/kubernetes/controllers/service_scan_controller.go - About 1 hr to fix

        Method ServiceScanReconciler.SetupWithManager has 6 return statements (exceeds 4 allowed).
        Open

        func (r *ServiceScanReconciler) SetupWithManager(mgr ctrl.Manager) error {
    // Check if scan names are unique
    if err := util.CheckUniquenessOfScanNames(r.Config.ContainerAutoDiscoveryConfig.ScanConfigs); err != nil {
        r.Log.Error(err, "Scan names are not unique")
        return err
        Severity: Major
        Found in auto-discovery/kubernetes/controllers/service_scan_controller.go - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status