Sign upLogin

secureCodeBox/secureCodeBox

View on GitHub
Star
operator/controllers/execution/scans/hook_reconciler.go

Summary

Maintainability
C
1 day
Test Coverage

Method ScanReconciler.createJobForHook has 143 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *ScanReconciler) createJobForHook(hookName string, hookSpec *executionv1.ScanCompletionHookSpec, scan *executionv1.Scan, cliArgs []string) (string, error) {
    ctx := context.Background()

    serviceAccountName := "scan-completion-hook"
    if hookSpec.ServiceAccountName != nil {
Severity: Major
Found in operator/controllers/execution/scans/hook_reconciler.go - About 4 hrs to fix

    Method ScanReconciler.processPendingHook has 82 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r *ScanReconciler) processPendingHook(scan *executionv1.Scan, status *executionv1.HookStatus, jobType string) error {
    ctx := context.Background()
    var err error

    var hookName string
    Severity: Major
    Found in operator/controllers/execution/scans/hook_reconciler.go - About 2 hrs to fix

      Method ScanReconciler.processPendingHook has 10 return statements (exceeds 4 allowed).
      Open

      func (r *ScanReconciler) processPendingHook(scan *executionv1.Scan, status *executionv1.HookStatus, jobType string) error {
    ctx := context.Background()
    var err error

    var hookName string
      Severity: Major
      Found in operator/controllers/execution/scans/hook_reconciler.go - About 1 hr to fix

        Method ScanReconciler.setHookStatus has 5 return statements (exceeds 4 allowed).
        Open

        func (r *ScanReconciler) setHookStatus(scan *executionv1.Scan) error {
    // Set (pending) Hook status on the scan
    ctx := context.Background()
    labelSelector, err := r.getLabelSelector(scan)
    if err != nil {
        Severity: Major
        Found in operator/controllers/execution/scans/hook_reconciler.go - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              resources := corev1.ResourceRequirements{
        Requests: corev1.ResourceList{
            corev1.ResourceCPU:    resource.MustParse("200m"),
            corev1.ResourceMemory: resource.MustParse("100Mi"),
        },
          Severity: Minor
          Found in operator/controllers/execution/scans/hook_reconciler.go and 1 other location - About 35 mins to fix
          operator/controllers/execution/scans/parse_reconciler.go on lines 126..135

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status