Sign upLogin

seeseemelk/MockBukkit

View on GitHub
Star

Showing 105 of 110 total issues

Method setGameRuleValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    @Override
    public boolean setGameRuleValue(String rule, String value)
    {
        if (rule == null)
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/WorldMock.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (mock != null)
        {
            JavaPlugin instance = mock.getPluginManager().loadPlugin(plugin, description, parameters);
            mock.getPluginManager().enablePlugin(instance);
            return plugin.cast(instance);
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java and 1 other location - About 45 mins to fix
src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java on lines 184..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (mock != null)
        {
            JavaPlugin instance = mock.getPluginManager().loadPlugin(plugin, descriptionFile, parameters);
            mock.getPluginManager().enablePlugin(instance);
            return plugin.cast(instance);
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java and 1 other location - About 45 mins to fix
src/main/java/be/seeseemelk/mockbukkit/MockBukkit.java on lines 269..278

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private int indexOf(PotionEffectType type)
    {
        for (int i = 0; i < effects.size(); ++i)
        {
            if (effects.get(i).getType().equals(type))
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java and 1 other location - About 40 mins to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java on lines 125..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private int indexOf(PotionEffectType type) {
        for (int i = 0; i < effects.size(); ++i) {
            if (effects.get(i).getType().equals(type)) {
                return i;
            }
Severity: Minor
Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/SuspiciousStewMetaMock.java and 1 other location - About 40 mins to fix
src/main/java/be/seeseemelk/mockbukkit/inventory/meta/PotionMetaMock.java on lines 162..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Consider simplifying this complex logical expression.
Open

            else if (obj != null && obj instanceof BanEntry)
            {
                BanEntry banEntry = (BanEntry) obj;
                return target.equals(banEntry.getTarget()) && expires.equals(banEntry.getExpiration()) && reason.equals(banEntry.getReason())
                        && source.equals(banEntry.getSource()) && created.equals(banEntry.getCreated());
Severity: Major
Found in src/main/java/be/seeseemelk/mockbukkit/MockBanList.java - About 40 mins to fix

    Method isConstructorCompatible has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private boolean isConstructorCompatible(Constructor<?> constructor, Class<?>[] types)
    {
        Class<?>[] parameters = constructor.getParameterTypes();
        for (int i = 0; i < types.length; i++)
        {
    Severity: Minor
    Found in src/main/java/be/seeseemelk/mockbukkit/plugin/PluginManagerMock.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method simulateBlockDamage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public boolean simulateBlockDamage(Block block)
    {
        if (gamemode == GameMode.SURVIVAL)
        {
            BlockDamageEvent event = simulateBlockDamagePure(block);
    Severity: Minor
    Found in src/main/java/be/seeseemelk/mockbukkit/entity/PlayerMock.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public ItemStack addItem(ItemStack item)
    {
        item = item.clone();
        for (int i = 0; i < items.length; i++)
        {
    Severity: Minor
    Found in src/main/java/be/seeseemelk/mockbukkit/inventory/InventoryMock.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getPlayer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public Player getPlayer(String name)
    {
        Player player = getPlayerExact(name);
        if (player != null)
    Severity: Minor
    Found in src/main/java/be/seeseemelk/mockbukkit/ServerMock.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setPage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void setPage(int page, String text)
    {
        if (!this.isValidPage(page))
        {
    Severity: Minor
    Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/BookMetaMock.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getPlayers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    @Deprecated
    public Set<OfflinePlayer> getPlayers() throws IllegalStateException {
        
        if(!registered)throw new IllegalStateException("Team not registered");
    Severity: Minor
    Found in src/main/java/be/seeseemelk/mockbukkit/scoreboard/TeamMock.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/ItemMetaMock.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return false;
      Severity: Major
      Found in src/main/java/be/seeseemelk/mockbukkit/WorldMock.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return setGameRule((GameRule<Boolean>) gameRule, value.equalsIgnoreCase("true"));
        Severity: Major
        Found in src/main/java/be/seeseemelk/mockbukkit/WorldMock.java - About 30 mins to fix

          Method callEvent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public void callEvent(Event event) throws IllegalStateException
    {
        events.add(event);
        for (List<ListenerEntry> listeners : eventListeners.values())
          Severity: Minor
          Found in src/main/java/be/seeseemelk/mockbukkit/plugin/PluginManagerMock.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method addCommandsFrom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected void addCommandsFrom(Plugin plugin)
    {
        Map<String, Map<String, Object>> commands = plugin.getDescription().getCommands();
        if (commands != null)
        {
          Severity: Minor
          Found in src/main/java/be/seeseemelk/mockbukkit/plugin/PluginManagerMock.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method addEnchant has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public boolean addEnchant(Enchantment ench, int level, boolean ignoreLevelRestriction) {
        Integer existingLevel = this.enchants.get(ench);
        if (nonNull(existingLevel) && existingLevel.equals(level)) {
            return false; // Already exists with the same level
          Severity: Minor
          Found in src/main/java/be/seeseemelk/mockbukkit/inventory/meta/ItemMetaMock.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Define and throw a dedicated exception instead of using a generic one.
          Open

                      throw new RuntimeException("Failed to instantiate plugin", e);
          Severity: Major
          Found in src/main/java/be/seeseemelk/mockbukkit/plugin/PluginManagerMock.java by sonar-java

          Using such generic exceptions as Error, RuntimeException, Throwable, and Exception prevents calling methods from handling true, system-generated exceptions differently than application-generated errors.

          Noncompliant Code Example

          public void foo(String bar) throws Throwable {  // Noncompliant
  throw new RuntimeException("My Message");     // Noncompliant
}

          Compliant Solution

          public void foo(String bar) {
  throw new MyOwnRuntimeException("My Message");
}

          Exceptions

          Generic exceptions in the signatures of overriding methods are ignored, because overriding method has to follow signature of the throw declaration in the superclass. The issue will be raised on superclass declaration of the method (or won't be raised at all if superclass is not part of the analysis).

          @Override
public void myMethod() throws Exception {...}

          Generic exceptions are also ignored in the signatures of methods that make calls to methods that throw generic exceptions.

          public void myOtherMethod throws Exception {
  doTheThing();  // this method throws Exception
}

          See

          Remove this "clone" implementation; use a copy constructor or copy factory instead.
          Open

              public @NotNull BlockData clone()
          Severity: Blocker
          Found in src/main/java/be/seeseemelk/mockbukkit/block/data/BlockDataMock.java by sonar-java

          Many consider clone and Cloneable broken in Java, largely because the rules for overriding clone are tricky and difficult to get right, according to Joshua Bloch:

          Object's clone method is very tricky. It's based on field copies, and it's "extra-linguistic." It creates an object without calling a constructor. There are no guarantees that it preserves the invariants established by the constructors. There have been lots of bugs over the years, both in and outside Sun, stemming from the fact that if you just call super.clone repeatedly up the chain until you have cloned an object, you have a shallow copy of the object. The clone generally shares state with the object being cloned. If that state is mutable, you don't have two independent objects. If you modify one, the other changes as well. And all of a sudden, you get random behavior.

          A copy constructor or copy factory should be used instead.

          This rule raises an issue when clone is overridden, whether or not Cloneable is implemented.

          Noncompliant Code Example

          public class MyClass {
  // ...

  public Object clone() { // Noncompliant
    //...
  }
}

          Compliant Solution

          public class MyClass {
  // ...

  MyClass (MyClass source) {
    //...
  }
}

          See

          See Also

          • {rule:java:S2157} - "Cloneables" should implement "clone"
          • {rule:java:S1182} - Classes that override "clone" should be "Cloneable" and call "super.clone()"
          Severity
          Category
          Status
          Source
          Language