segura2010/CC-Proyecto-OpenSecureChat

View on GitHub

Showing 18 of 18 total issues

File index.js has 584 lines of code (exceeds 250 allowed). Consider refactoring.
Open


var JSE = null;
var socket = null;

var SOCKETIO_URL = "";
Severity: Major
Found in public_html/js/own_components/index.js - About 1 day to fix

    File app.js has 355 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    
    // Get config from enviroment vars
    var PORT = process.env.PORT || 3000;
    var URI = process.env.URI || "localhost";
    var KEY_SIZE = process.env.KEY_SIZE || 2048;
    Severity: Minor
    Found in app.js - About 4 hrs to fix

      Function exports has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {
      
        // Configuración del proyecto
        grunt.initConfig({
          pkg: grunt.file.readJSON('package.json'),
      Severity: Major
      Found in Gruntfile.js - About 2 hrs to fix

        Function UserController has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.UserController = function(colecc, redis){
        
            // Coleccion de la BD Mongo
            this.coleccion = colecc;
            // DB Redis
        Severity: Major
        Found in lib/User.js - About 2 hrs to fix

          Function UploadedFileController has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.UploadedFileController = function(colecc){
          
              // Coleccion de la BD Mongo
              this.coleccion = colecc;
          
          
          Severity: Minor
          Found in lib/UploadedFile.js - About 1 hr to fix

            Function getMessageChatTemplate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function getMessageChatTemplate(username, message, isMe, isUnread, isFile)
            {
                var alignClass = "align-right";
                var myMessage = "message my-message";
                var otherMessage = "message other-message float-right";
            Severity: Minor
            Found in public_html/js/own_components/index.js - About 1 hr to fix

              Function uploadFile has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function uploadFile(evt)
              {
                  var f = evt.target.files[0];
              
                  var reader = new FileReader();
              Severity: Minor
              Found in public_html/js/own_components/index.js - About 1 hr to fix

                Function ChatController has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                exports.ChatController = function(db){
                
                    // Redis Client
                    this.dbredis = db;
                
                
                Severity: Minor
                Found in lib/Chat.js - About 1 hr to fix

                  Function onload has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      reader.onload = (function(theFile) {
                          return function(e) {
                  
                              var username = $("#chatWith").html();
                  
                  
                  Severity: Minor
                  Found in public_html/js/own_components/index.js - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        this.update = function(id, data, cb){
                            var c = this.coleccion;
                            c.update({_id:id}, { $set:data }, cb);
                        };
                    Severity: Major
                    Found in lib/User.js and 1 other location - About 1 hr to fix
                    lib/UploadedFile.js on lines 29..32

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        this.update = function(id, data, cb){
                            var c = this.coleccion;
                            c.update({_id:id}, { $set:data }, cb);
                        };
                    Severity: Major
                    Found in lib/UploadedFile.js and 1 other location - About 1 hr to fix
                    lib/User.js on lines 49..52

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function add has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        this.add = function(userid, touserid, encryptedMsgUser, encryptedMsgToUser, isFile, cb){
                    Severity: Minor
                    Found in lib/Chat.js - About 45 mins to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          this.getUsersById = function(ids, cb){
                              // Get user by ID
                              this.coleccion.find({_id:{ "$in": ids } }, cb);
                          };
                      Severity: Minor
                      Found in lib/User.js and 2 other locations - About 40 mins to fix
                      lib/UploadedFile.js on lines 59..62
                      lib/User.js on lines 79..82

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          this.search = function(username, cb){
                              // Search user by username
                              this.coleccion.find({username:{"$regex":username}}, cb);
                          };
                      Severity: Minor
                      Found in lib/User.js and 2 other locations - About 40 mins to fix
                      lib/UploadedFile.js on lines 59..62
                      lib/User.js on lines 59..62

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          this.search = function(name, cb){
                              // Search file by name
                              this.coleccion.find({name:{"$regex":name}}, cb);
                          };
                      Severity: Minor
                      Found in lib/UploadedFile.js and 2 other locations - About 40 mins to fix
                      lib/User.js on lines 59..62
                      lib/User.js on lines 79..82

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function getMessageChatTemplate has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function getMessageChatTemplate(username, message, isMe, isUnread, isFile)
                      Severity: Minor
                      Found in public_html/js/own_components/index.js - About 35 mins to fix

                        Function renderChatMessages has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function renderChatMessages(messages, username)
                        {
                            markAsRead(username);
                            var user = searchUserInfoOnCache(username);
                            $("#chatWindow").html("");
                        Severity: Minor
                        Found in public_html/js/own_components/index.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function newMessageRecived has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function newMessageRecived(data)
                        {
                        
                            if(!searchUserInfoOnCache(data.username))
                            {
                        Severity: Minor
                        Found in public_html/js/own_components/index.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language