Sign upLogin

serp-spider/core

View on GitHub
Star

Showing 48 of 48 total issues

Function formGetData has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    public function formGetData(\DOMElement $formNode, array $formData = [], $strict = true, $submit = true)
    {

        $items = $this->xpathQuery('(//input | //textarea | //select)', $formNode);
        $consumed = [];
Severity: Minor
Found in src/Core/Dom/WebPage.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * @license see LICENSE
 */
Severity: Major
Found in src/Core/UrlArchive.php and 1 other location - About 7 hrs to fix
src/Core/Url.php on lines 1..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 226.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * @license see LICENSE
 */
Severity: Major
Found in src/Core/Url.php and 1 other location - About 7 hrs to fix
src/Core/UrlArchive.php on lines 1..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 226.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File UrlArchiveTrait.php has 331 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @license see LICENSE
 */
Severity: Minor
Found in src/Core/Url/UrlArchiveTrait.php - About 3 hrs to fix

    Function resolveAsAlterableUrl has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private function resolveAsAlterableUrl($url, $as)
    {
        $delta = call_user_func([$as, 'fromString'], $url);

        if (!($scheme = $delta->getScheme())) {
    Severity: Minor
    Found in src/Core/Url/UrlArchiveTrait.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method formGetData has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formGetData(\DOMElement $formNode, array $formData = [], $strict = true, $submit = true)
    {

        $items = $this->xpathQuery('(//input | //textarea | //select)', $formNode);
        $consumed = [];
    Severity: Major
    Found in src/Core/Dom/WebPage.php - About 2 hrs to fix

      Function set has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public function set(Cookie $cookie)
    {
        $result = $cookie->validate();
        if ($result !== true) {
            if ($this->strictMode) {
      Severity: Minor
      Found in src/Core/Cookie/ArrayCookieJar.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parse has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function parse($string, $host, $path, $decode = false)
    {

        // Explode the cookie string using a series of semicolons
        $pieces = array_filter(array_map('trim', explode(';', $string)));
      Severity: Minor
      Found in src/Core/Cookie/SetCookieString.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getData has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getData()
    {
        $data = [];
        foreach ($this->data as $k => $v) {
            $datum = $this->getDataValue($k);
      Severity: Minor
      Found in src/Core/Serp/BaseResult.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method resolveAsAlterableUrl has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function resolveAsAlterableUrl($url, $as)
    {
        $delta = call_user_func([$as, 'fromString'], $url);

        if (!($scheme = $delta->getScheme())) {
      Severity: Minor
      Found in src/Core/Url/UrlArchiveTrait.php - About 1 hr to fix

        Function parseSelect has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private function parseSelect(\DOMElement $select, array $formData, array &$consumed)
    {

        $name = strtolower($select->getAttribute('name'));
        Severity: Minor
        Found in src/Core/Dom/WebPage.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function parse($string, $host, $path, $decode = false)
    {

        // Explode the cookie string using a series of semicolons
        $pieces = array_filter(array_map('trim', explode(';', $string)));
        Severity: Minor
        Found in src/Core/Cookie/SetCookieString.php - About 1 hr to fix

          Function arrayToStringRecursive has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              private function arrayToStringRecursive($currentKey, $dataArray)
    {
        $data = [];
        foreach ($dataArray as $k => $v) {
            $key = "${currentKey}[${k}]";
          Severity: Minor
          Found in src/Core/Url/QueryParam.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getAuthority has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getAuthority()
    {
        $authority = '';

        if ($host = $this->getHost()) {
          Severity: Minor
          Found in src/Core/Url/UrlArchiveTrait.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parseStr has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function parseStr($str)
    {

        if (!$str) {
            return [];
          Severity: Minor
          Found in src/Core/Url/UrlArchiveTrait.php - About 1 hr to fix

            Method set has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function set(Cookie $cookie)
    {
        $result = $cookie->validate();
        if ($result !== true) {
            if ($this->strictMode) {
            Severity: Minor
            Found in src/Core/Cookie/ArrayCookieJar.php - About 1 hr to fix

              Function createFromString has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function createFromString($proxy)
    {

        if (preg_match('#^[a-zA-Z0-9]+://#', $proxy)) {
            list($type, $proxy) = explode('://', $proxy, 2);
              Severity: Minor
              Found in src/Core/Http/Proxy.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method requestFromForm has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function requestFromForm(
        \DOMElement $formNode,
        array $formData = [],
        $strict = true,
        $submit = true,
              Severity: Minor
              Found in src/Core/Dom/WebPage.php - About 1 hr to fix

                Method parseInput has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function parseInput(\DOMElement $input, array $formData, array &$consumed)
    {
        $name = strtolower($input->getAttribute('name'));

        if (!$name) {
                Severity: Minor
                Found in src/Core/Dom/WebPage.php - About 1 hr to fix

                  Method parseSelect has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function parseSelect(\DOMElement $select, array $formData, array &$consumed)
    {

        $name = strtolower($select->getAttribute('name'));
                  Severity: Minor
                  Found in src/Core/Dom/WebPage.php - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language