serp-spider/core

View on GitHub

Showing 48 of 48 total issues

Function cloneAs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function cloneAs($as = null)
    {

        if (null === $as) {
            $as = static::class;
Severity: Minor
Found in src/Core/Url/UrlArchiveTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/Core/Cookie/Cookie.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return (string) $this->getName();
    Severity: Major
    Found in src/Core/Url/QueryParam.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return urlencode($name);
      Severity: Major
      Found in src/Core/Dom/WebPage.php - About 30 mins to fix

        Function hasClasses has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function hasClasses(array $classNames)
            {
                $classList = $this->getClassList();
        
                if (!empty($classList)) {
        Severity: Minor
        Found in src/Core/Dom/DomElement.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function requestFromForm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function requestFromForm(
                \DOMElement $formNode,
                array $formData = [],
                $strict = true,
                $submit = true,
        Severity: Minor
        Found in src/Core/Dom/WebPage.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function matchesPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function matchesPath($path)
            {
        
                $cookiePath = $this->getPath();
        
        
        Severity: Minor
        Found in src/Core/Cookie/Cookie.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildUrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function buildUrl()
            {
                $scheme = $this->getScheme();
                if ($scheme) {
                    $uri = $scheme . ':';
        Severity: Minor
        Found in src/Core/Url/UrlArchiveTrait.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language