Sign upLogin

serp-spider/core

View on GitHub
Star
src/Core/Dom/WebPage.php

Summary

Maintainability
D
2 days
Test Coverage

Function formGetData has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    public function formGetData(\DOMElement $formNode, array $formData = [], $strict = true, $submit = true)
    {

        $items = $this->xpathQuery('(//input | //textarea | //select)', $formNode);
        $consumed = [];
Severity: Minor
Found in src/Core/Dom/WebPage.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method formGetData has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function formGetData(\DOMElement $formNode, array $formData = [], $strict = true, $submit = true)
    {

        $items = $this->xpathQuery('(//input | //textarea | //select)', $formNode);
        $consumed = [];
Severity: Major
Found in src/Core/Dom/WebPage.php - About 2 hrs to fix

    Function parseSelect has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        private function parseSelect(\DOMElement $select, array $formData, array &$consumed)
    {

        $name = strtolower($select->getAttribute('name'));
    Severity: Minor
    Found in src/Core/Dom/WebPage.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method requestFromForm has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function requestFromForm(
        \DOMElement $formNode,
        array $formData = [],
        $strict = true,
        $submit = true,
    Severity: Minor
    Found in src/Core/Dom/WebPage.php - About 1 hr to fix

      Method parseInput has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function parseInput(\DOMElement $input, array $formData, array &$consumed)
    {
        $name = strtolower($input->getAttribute('name'));

        if (!$name) {
      Severity: Minor
      Found in src/Core/Dom/WebPage.php - About 1 hr to fix

        Method parseSelect has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function parseSelect(\DOMElement $select, array $formData, array &$consumed)
    {

        $name = strtolower($select->getAttribute('name'));
        Severity: Minor
        Found in src/Core/Dom/WebPage.php - About 1 hr to fix

          Function parseInput has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private function parseInput(\DOMElement $input, array $formData, array &$consumed)
    {
        $name = strtolower($input->getAttribute('name'));

        if (!$name) {
          Severity: Minor
          Found in src/Core/Dom/WebPage.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method requestFromForm has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  \DOMElement $formNode,
        array $formData = [],
        $strict = true,
        $submit = true,
        RequestInterface $request = null
          Severity: Minor
          Found in src/Core/Dom/WebPage.php - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                                return urlencode($name);
            Severity: Major
            Found in src/Core/Dom/WebPage.php - About 30 mins to fix

              Function requestFromForm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function requestFromForm(
        \DOMElement $formNode,
        array $formData = [],
        $strict = true,
        $submit = true,
              Severity: Minor
              Found in src/Core/Dom/WebPage.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status