Sign upLogin

sformisano/jetski-router

View on GitHub
Star
src/RequestDispatcher.php

Summary

Maintainability
A
0 mins
Test Coverage

shouldReturnJson accesses the super-global variable $_GET.
Open

  private function shouldReturnJson()
  {
    return (
      isset($_GET['json']) ||
      $this->outputFormat === 'json' ||
Severity: Minor
Found in src/RequestDispatcher.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

shouldReturnJson accesses the super-global variable $_SERVER.
Open

  private function shouldReturnJson()
  {
    return (
      isset($_GET['json']) ||
      $this->outputFormat === 'json' ||
Severity: Minor
Found in src/RequestDispatcher.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

shouldReturnJson accesses the super-global variable $_SERVER.
Open

  private function shouldReturnJson()
  {
    return (
      isset($_GET['json']) ||
      $this->outputFormat === 'json' ||
Severity: Minor
Found in src/RequestDispatcher.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

There are no issues that match your filters.

Category
Status