Sign upLogin

sgammon/canteen

View on GitHub
Star

Showing 1,384 of 1,384 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def __init__(self, requested, rollup=True, notify=False):

    """ Initialize this ``HookResponder`` ``Context`` object.

        :param requested: Context items that are explicitly requested to be
Severity: Major
Found in canteen/core/hooks.py and 2 other locations - About 40 mins to fix
canteen/logic/http/agent.py on lines 80..88
canteen/model/query.py on lines 1022..1034

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if not parts and formats.get('urlsafe'):
      return cls.from_urlsafe(formats['urlsafe'])
Severity: Minor
Found in canteen/model/__init__.py and 1 other location - About 40 mins to fix
canteen/model/__init__.py on lines 1180..1181

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def __init__(self, major, minor=None, micro=None):

    """ Initialize this version info container.

        :param major: Major version.
Severity: Major
Found in canteen/logic/http/agent.py and 2 other locations - About 40 mins to fix
canteen/core/hooks.py on lines 121..137
canteen/model/query.py on lines 1022..1034

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def __init__(self, prop, type=PROPERTY, operator=ASC):

    """ Initialize this :py:class:`Sort`.

        :param prop: Subject property to sort upon.
Severity: Major
Found in canteen/model/query.py and 2 other locations - About 40 mins to fix
canteen/core/hooks.py on lines 121..137
canteen/logic/http/agent.py on lines 80..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      for key, value in (map.iteritems() if isinstance(map, dict) else map):
        self.set(key, value)
Severity: Minor
Found in canteen/logic/cache.py and 1 other location - About 40 mins to fix
canteen/logic/cache.py on lines 610..611

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def render(self, handler, config, template, ctx, _direct=False):
Severity: Minor
Found in canteen/logic/template.py - About 35 mins to fix

Function execute_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def execute_query(cls, kind, spec, options, **kwargs):  # pragma: no cover
Severity: Minor
Found in canteen/model/adapter/redis.py - About 35 mins to fix

Function execute has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def execute(cls, operation, kind, *args, **kwargs):
Severity: Minor
Found in canteen/model/adapter/redis.py - About 35 mins to fix

Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def run(app=None,
Severity: Minor
Found in canteen/dispatch.py - About 35 mins to fix

Function commit has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def commit(self, status, headers, request, http, response):
Severity: Minor
Found in canteen/logic/session.py - About 35 mins to fix

Function put has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def put(cls, key, entity, model, pipeline=None):
Severity: Minor
Found in canteen/model/adapter/redis.py - About 35 mins to fix

Function allocate_ids has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def allocate_ids(cls, key_class, kind, count=1, pipeline=None):
Severity: Minor
Found in canteen/model/adapter/redis.py - About 35 mins to fix

Function write_indexes has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def write_indexes(cls, w, g, pipeline=None, execute=True):
Severity: Minor
Found in canteen/model/adapter/redis.py - About 35 mins to fix

Function establish has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def establish(self, environ, endpoint, arguments, request, http):
Severity: Minor
Found in canteen/logic/session.py - About 35 mins to fix

Function execute_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def execute_query(cls, kind, spec, options, **kwargs):
Severity: Minor
Found in canteen/model/adapter/abstract.py - About 35 mins to fix

Function resolve has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def resolve(mcs, name, bases, properties, default=True):
Severity: Minor
Found in canteen/model/__init__.py - About 35 mins to fix

Function compile has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def compile(self, environment, source, destination,
Severity: Minor
Found in canteen/logic/template.py - About 35 mins to fix

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def __init__(self, value,
Severity: Minor
Found in canteen/model/query.py - About 35 mins to fix

Function _pluck_indexed has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def _pluck_indexed(entity):

    """ Override the indexed property scanner to ignore ``Edge``-related auto-
        injected properties.
Severity: Minor
Found in canteen/model/adapter/abstract.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function commit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def commit(self, request, response, session):

        """  """

        # resolve serializer
Severity: Minor
Found in canteen/logic/http/cookies.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language