sh19910711/git-contest

View on GitHub
lib/contest/driver/aizu_online_judge_driver.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method submit_ext has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def submit_ext
        # start
        trigger 'start'
        problem_id = normalize_problem_id(@options[:problem_id])

Severity: Minor
Found in lib/contest/driver/aizu_online_judge_driver.rb - About 1 hr to fix

    Method resolve_language has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def resolve_language(label)
            case label
            when "clang"
              return "C"
            when "cpp"
    Severity: Minor
    Found in lib/contest/driver/aizu_online_judge_driver.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                return "PHP"
      Severity: Major
      Found in lib/contest/driver/aizu_online_judge_driver.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return "JavaScript"
        Severity: Major
        Found in lib/contest/driver/aizu_online_judge_driver.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return "C#"
          Severity: Major
          Found in lib/contest/driver/aizu_online_judge_driver.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return "Ruby"
            Severity: Major
            Found in lib/contest/driver/aizu_online_judge_driver.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return "Python3"
              Severity: Major
              Found in lib/contest/driver/aizu_online_judge_driver.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return "Python"
                Severity: Major
                Found in lib/contest/driver/aizu_online_judge_driver.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                            return "D"
                  Severity: Major
                  Found in lib/contest/driver/aizu_online_judge_driver.rb - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            5.times do
                              sleep 3
                              status_page = @client.get "http://judge.u-aizu.ac.jp/onlinejudge/webservice/status_log?user_id=#{user_id}&limit=1"
                              status = get_status(submission_id, status_page.body)
                              return status unless is_waiting(submission_id, status_page.body)
                    Severity: Minor
                    Found in lib/contest/driver/aizu_online_judge_driver.rb and 1 other location - About 20 mins to fix
                    lib/contest/driver/codeforces_driver.rb on lines 164..169

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 27.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status