Sign upLogin

shioyama/mobility

View on GitHub
Star
lib/mobility/backends/active_record/table.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method configure has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
Open

        def configure(options)
          table_name = model_class.table_name
          options[:table_name]  ||= "#{table_name.singularize}_translations"
          options[:foreign_key] ||= table_name.downcase.singularize.camelize.foreign_key
          if (association_name = options[:association_name]).present?
Severity: Minor
Found in lib/mobility/backends/active_record/table.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

FIXME found
Wontfix

              # FIXME: do this better
Severity: Minor
Found in lib/mobility/backends/active_record/table.rb by fixme

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Invalid

          if join_type = visitor.accept(predicate)
Severity: Minor
Found in lib/mobility/backends/active_record/table.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Invalid

          if join = get_join(relation, locale)
Severity: Minor
Found in lib/mobility/backends/active_record/table.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

end at 117, 12 is not aligned with if at 113, 10.
Open

            end
Severity: Minor
Found in lib/mobility/backends/active_record/table.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

There are no issues that match your filters.

Category
Status