Sign upLogin

shootismoke/backend

View on GitHub
Star

Showing 6 of 6 total issues

Function receipts has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function receipts(_req: NowRequest, res: NowResponse): Promise<void> {
    try {
        await connectToDatabase(process.env.MONGODB_ATLAS_URI);

        const tickets = await PushTicket.find({
Severity: Minor
Found in src/api/receipts.ts - About 1 hr to fix

    Function push has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function push(_req: NowRequest, res: NowResponse): Promise<void> {
    try {
        await connectToDatabase(process.env.MONGODB_ATLAS_URI);

        // Fetch all users to whom we should show a notification
    Severity: Minor
    Found in src/api/push.ts - About 1 hr to fix

      Function expoMessageForUser has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function expoMessageForUser(
    user: User & Document
): Promise<UserExpoMessage> {
    try {
        // Find the PM2.5 value at the user's last known station (universalId)
      Severity: Minor
      Found in src/push/provider.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            try {
        await connectToDatabase(process.env.MONGODB_ATLAS_URI);

        const tickets = await PushTicket.find({
            receiptId: { $exists: true },
        Severity: Major
        Found in src/api/receipts.ts and 1 other location - About 1 hr to fix
        src/api/push.ts on lines 22..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            try {
        await connectToDatabase(process.env.MONGODB_ATLAS_URI);

        // Fetch all users to whom we should show a notification
        const users = await findUsersForNotifications();
        Severity: Major
        Found in src/api/push.ts and 1 other location - About 1 hr to fix
        src/api/receipts.ts on lines 15..67

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function handleReceipts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        export async function handleReceipts(
    expo: Expo,
    receiptIds: string[],
    onOk: (receiptId: ExpoPushReceiptId, receipt: ExpoPushReceipt) => void,
    onError: (receiptId: ExpoPushReceiptId, receipt: ExpoPushReceipt) => void
        Severity: Minor
        Found in src/push/expo.ts - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language