shootismoke/common

View on GitHub

Showing 16 of 19 total issues

Function renderCigarette has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function renderCigarette(
    orientation: 'horizontal' | 'vertical',
    percentage: number,
    fullCigaretteLength: number,
    additionalStyle?: StyleProp<ViewStyle>
Severity: Major
Found in packages/ui/src/components/Cigarettes/Cigarette/Cigarette.tsx - About 2 hrs to fix

    Function fetchAlgolia has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function fetchAlgolia(
        search: string,
        gps?: LatLng
    ): TE.TaskEither<Error, AlgoliaHit[]> {
        return retry(
    Severity: Major
    Found in packages/ui/src/util/fetchAlgolia.ts - About 2 hrs to fix

      Function Cigarettes has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function Cigarettes(props: CigarettesProps): React.ReactElement {
          const {
              cigarettes: realCigarettes,
              cigaretteStyle,
              fullCigaretteLength = 90,
      Severity: Major
      Found in packages/ui/src/components/Cigarettes/Cigarettes.tsx - About 2 hrs to fix

        Function testTE has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function testTE<T>(
            te: TE.TaskEither<Error, T>,
            normalize: (data: T) => E.Either<Error, OpenAQResults>,
            done: jest.DoneCallback
        ): void {
        Severity: Minor
        Found in packages/dataproviders/test/util/testUtil.ts - About 1 hr to fix

          Function Cigarettes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          export function Cigarettes(props: CigarettesProps): React.ReactElement {
              const {
                  cigarettes: realCigarettes,
                  cigaretteStyle,
                  fullCigaretteLength = 90,
          Severity: Minor
          Found in packages/ui/src/components/Cigarettes/Cigarettes.tsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const d2 =
                  Math.abs(currentLocation.latitude - station.longitude) +
                  Math.abs(currentLocation.longitude - station.latitude);
          Severity: Minor
          Found in packages/ui/src/util/station.ts and 1 other location - About 50 mins to fix
          packages/ui/src/util/station.ts on lines 58..60

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const d1 =
                  Math.abs(currentLocation.latitude - station.latitude) +
                  Math.abs(currentLocation.longitude - station.longitude);
          Severity: Minor
          Found in packages/ui/src/util/station.ts and 1 other location - About 50 mins to fix
          packages/ui/src/util/station.ts on lines 62..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  fromUgm3(pollutant: Pollutant, ugm3: number): number {
                      assertTracked(aqiCode, pollutant, breakpoints);
          
                      return fromUgm3(breakpoints.aqi, breakpoints[pollutant], ugm3);
                  },
          Severity: Minor
          Found in packages/convert/src/util/breakpoints.ts and 1 other location - About 45 mins to fix
          packages/convert/src/util/breakpoints.ts on lines 146..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  toUgm3(pollutant: Pollutant, value: number): number {
                      assertTracked(aqiCode, pollutant, breakpoints);
          
                      return toUgm3(breakpoints.aqi, breakpoints[pollutant], value);
                  },
          Severity: Minor
          Found in packages/convert/src/util/breakpoints.ts and 1 other location - About 45 mins to fix
          packages/convert/src/util/breakpoints.ts on lines 140..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Consider simplifying this complex logical expression.
          Open

              if (
                  from === 'ppb' ||
                  from === 'ppm' ||
                  from === 'particles/cm³' ||
                  to === 'ppb' ||
          Severity: Major
          Found in packages/convert/src/convert.ts - About 40 mins to fix

            Function normalize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function normalize(data: AqicnStaton): E.Either<Error, OpenAQResults> {
                if (!data || typeof data === 'string') {
                    return E.left(
                        providerError('aqicn', `Cannot normalized ${data || 'undefined'}`)
                    );
            Severity: Minor
            Found in packages/dataproviders/src/providers/aqicn/normalize.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            style={[
                                styles.inner,
                                orientation === 'horizontal'
                                    ? {
                                            height: '100%',
            Severity: Minor
            Found in packages/ui/src/components/Cigarettes/Cigarette/Cigarette.tsx and 1 other location - About 35 mins to fix
            packages/ui/src/components/Cigarettes/Cigarette/Cigarette.tsx on lines 162..173

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                style={[
                                    styles.butt,
                                    orientation === 'horizontal'
                                        ? {
                                                height: '100%',
            Severity: Minor
            Found in packages/ui/src/components/Cigarettes/Cigarette/Cigarette.tsx and 1 other location - About 35 mins to fix
            packages/ui/src/components/Cigarettes/Cigarette/Cigarette.tsx on lines 143..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export const pollutantCodec = t.union(
                // eslint-disable-next-line @typescript-eslint/ban-ts-comment
                // @ts-ignore We're sure there's at list one element.
                AllPollutants.map((pol) => t.literal(pol))
            );
            Severity: Minor
            Found in packages/dataproviders/src/util/openaq.ts and 1 other location - About 30 mins to fix
            packages/dataproviders/src/util/openaq.ts on lines 44..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export const unitCodec = t.union(
                // eslint-disable-next-line @typescript-eslint/ban-ts-comment
                // @ts-ignore We're sure there's at list one element.
                AllUnits.map((u) => t.literal(u))
            );
            Severity: Minor
            Found in packages/dataproviders/src/util/openaq.ts and 1 other location - About 30 mins to fix
            packages/dataproviders/src/util/openaq.ts on lines 35..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                return pipe(
                    getCountryCode(countryRaw),
                    E.fromOption(() =>
                        providerError('aqicn', `Cannot get code from country ${countryRaw}`)
                    ),
            Severity: Major
            Found in packages/dataproviders/src/providers/aqicn/normalize.ts - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language