shootismoke/common

View on GitHub

Showing 8 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const d1 =
Math.abs(currentLocation.latitude - station.latitude) +
Math.abs(currentLocation.longitude - station.longitude);
Severity: Minor
Found in packages/ui/src/util/station.ts and 1 other location - About 50 mins to fix
packages/ui/src/util/station.ts on lines 62..64

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const d2 =
Math.abs(currentLocation.latitude - station.longitude) +
Math.abs(currentLocation.longitude - station.latitude);
Severity: Minor
Found in packages/ui/src/util/station.ts and 1 other location - About 50 mins to fix
packages/ui/src/util/station.ts on lines 58..60

Similar blocks of code found in 2 locations. Consider refactoring.
Open

fromUgm3(pollutant: Pollutant, ugm3: number): number {
assertTracked(aqiCode, pollutant, breakpoints);
 
return fromUgm3(breakpoints.aqi, breakpoints[pollutant], ugm3);
},
Severity: Minor
Found in packages/convert/src/util/breakpoints.ts and 1 other location - About 45 mins to fix
packages/convert/src/util/breakpoints.ts on lines 146..150

Similar blocks of code found in 2 locations. Consider refactoring.
Open

toUgm3(pollutant: Pollutant, value: number): number {
assertTracked(aqiCode, pollutant, breakpoints);
 
return toUgm3(breakpoints.aqi, breakpoints[pollutant], value);
},
Severity: Minor
Found in packages/convert/src/util/breakpoints.ts and 1 other location - About 45 mins to fix
packages/convert/src/util/breakpoints.ts on lines 140..144

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const openaq: Provider<OpenAQMeasurements, OpenAQOptions> = {
fetchByGps,
fetchByStation,
id: 'openaq',
name: 'Open AQ',
Severity: Minor
Found in packages/dataproviders/src/providers/openaq/openaq.ts and 1 other location - About 40 mins to fix
packages/dataproviders/src/providers/aqicn/aqicn.ts on lines 9..15

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const aqicn: Provider<AqicnData, AqicnOptions> = {
fetchByGps,
fetchByStation,
id: 'aqicn',
name: 'AQI CN',
Severity: Minor
Found in packages/dataproviders/src/providers/aqicn/aqicn.ts and 1 other location - About 40 mins to fix
packages/dataproviders/src/providers/openaq/openaq.ts on lines 6..12

Consider simplifying this complex logical expression.
Open

if (
from === 'ppb' ||
from === 'ppm' ||
from === 'particles/cm³' ||
to === 'ppb' ||
Severity: Major
Found in packages/convert/src/convert.ts - About 40 mins to fix

    Function normalize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export function normalize(data: AqicnData): OpenAQResults {
    const stationId = `aqicn|${data.idx}`;
     
    // Sometimes we don't get geo
    if (!data.city.geo) {
    Severity: Minor
    Found in packages/dataproviders/src/providers/aqicn/normalize.ts - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language