Showing 9,050 of 9,050 total issues
Method subscribe
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public synchronized Destination subscribe(final StompServerConnection connection, final Frame frame) {
final String address = frame.getDestination();
/*
* Need to check whether the client can receive message from the event bus (outbound).
Method equals
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public boolean equals(Object obj) {
if (this == obj)
return true;
if (obj == null)
Method toJson
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public default io.vertx.core.json.JsonObject toJson() {
io.vertx.core.json.JsonObject json = new io.vertx.core.json.JsonObject();
json.put("KEY",getKey());
json.put("NAME",getName());
Method fromJson
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public default IECompany fromJson(io.vertx.core.json.JsonObject json) {
setOrThrow(this::setKey,json::getString,"KEY","java.lang.String");
setOrThrow(this::setName,json::getString,"NAME","java.lang.String");
setOrThrow(this::setAlias,json::getString,"ALIAS","java.lang.String");
Method fromJson
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public default IIApi fromJson(io.vertx.core.json.JsonObject json) {
setOrThrow(this::setKey,json::getString,"KEY","java.lang.String");
setOrThrow(this::setName,json::getString,"NAME","java.lang.String");
setOrThrow(this::setUri,json::getString,"URI","java.lang.String");
Method hashCode
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((this.key == null) ? 0 : this.key.hashCode());
Method toString
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public String toString() {
StringBuilder sb = new StringBuilder("BBlock (");
sb.append(key);
Method from
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public void from(IPCommodity from) {
setKey(from.getKey());
setName(from.getName());
setCode(from.getCode());
Method toString
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public String toString() {
StringBuilder sb = new StringBuilder("POutItem (");
sb.append(key);
Method hashCode
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((this.key == null) ? 0 : this.key.hashCode());
Method from
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public void from(IPCommodity from) {
setKey(from.getKey());
setName(from.getName());
setCode(from.getCode());
Method fromJson
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public default IPBuyItem fromJson(io.vertx.core.json.JsonObject json) {
setOrThrow(this::setKey,json::getString,"KEY","java.lang.String");
setOrThrow(this::setSerial,json::getString,"SERIAL","java.lang.String");
setOrThrow(this::setStatus,json::getString,"STATUS","java.lang.String");
Method toString
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public String toString() {
StringBuilder sb = new StringBuilder("FInvoice (");
sb.append(key);
Method hashCode
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((this.key == null) ? 0 : this.key.hashCode());
Method fromJson
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public default IFBillItem fromJson(io.vertx.core.json.JsonObject json) {
setOrThrow(this::setKey,json::getString,"KEY","java.lang.String");
setOrThrow(this::setName,json::getString,"NAME","java.lang.String");
setOrThrow(this::setCode,json::getString,"CODE","java.lang.String");
Method hashCode
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + ((this.key == null) ? 0 : this.key.hashCode());
Method toString
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public String toString() {
StringBuilder sb = new StringBuilder("IIntegration (");
sb.append(key);
Method toJson
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public default io.vertx.core.json.JsonObject toJson() {
io.vertx.core.json.JsonObject json = new io.vertx.core.json.JsonObject();
json.put("KEY",getKey());
json.put("NAME",getName());
Method runJAsync
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public Future<JsonObject> runJAsync(final JsonObject input, final IxMod in) {
final JsonObject condition = this.module.dataCond(input);
final KModule standBy = in.module();
final UxJooq jooq = IxPin.jooq(in);
Similar blocks of code found in 6 locations. Consider refactoring. Open
interface Job {
String START = Prefix._EVENT + "I-JOB/START";
String STOP = Prefix._EVENT + "I-JOB/STOP";
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 86.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76