Sign upLogin

sixty-nine/php-cloud-lib

View on GitHub
Star

Showing 108 of 109 total issues

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'getNamedPalette'.
Open

        Assert::keyExists($this->palettes, $name, 'Palette not found: ' . $name);
Severity: Minor
Found in src/SixtyNine/Cloud/Builder/PalettesBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'build'.
Open

        Assert::notNull($this->font, 'Font not set');
Severity: Minor
Found in src/SixtyNine/Cloud/Builder/CloudBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'importPalettes'.
Open

        Assert::keyExists($yml, 'palettes', 'Invalid palettes YAML');
Severity: Minor
Found in src/SixtyNine/Cloud/Builder/PalettesBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'insertWords'.
Open

            Assert::fileExists($file, 'File not found: ' . $file);
Severity: Minor
Found in src/SixtyNine/Cloud/Command/CommandsHelper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'getImage'.
Open

        Assert::notNull($this->image, 'Image not created');
Severity: Minor
Found in src/SixtyNine/Cloud/Drawer/Drawer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SixtyNine\Cloud\Factory\Logger' in method '__construct'.
Open

        $this->logger = Logger::getInstance();
Severity: Minor
Found in src/SixtyNine/Cloud/Usher/Usher.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'getColorGenerator'.
Open

            Assert::oneOf($paletteType, $this->paletteTypes, 'Palette type must be either "cycle" or "random"');
Severity: Minor
Found in src/SixtyNine/Cloud/Command/CommandsHelper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'getFont'.
Open

        Assert::notEmpty($factory->getFonts(), 'No font file found');
Severity: Minor
Found in src/SixtyNine/Cloud/Command/CommandsHelper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SixtyNine\Cloud\Factory\Logger' in method '__construct'.
Open

        $this->logger = Logger::getInstance();
Severity: Minor
Found in src/SixtyNine/Cloud/Usher/QuadTreeMask.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'sortWords'.
Open

        Assert::oneOf($sortOrder, $this->allowedSortOrder, 'Invalid sort order: ' . $sortOrder);
Severity: Minor
Found in src/SixtyNine/Cloud/Model/WordsList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SixtyNine\Cloud\Factory\FontsFactory' in method 'createCloud'.
Open

        $factory = FontsFactory::create($fontsPath);
Severity: Minor
Found in src/SixtyNine/Cloud/Command/CommandsHelper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SixtyNine\Cloud\Factory\FontsFactory' in method 'execute'.
Open

        $renderer = new CloudRenderer($cloud, FontsFactory::create(BASE_PATH . '/fonts'));
Severity: Minor
Found in src/SixtyNine/Cloud/Command/DebugUsherCommand.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'getPlacer'.
Open

        Assert::notEmpty($availablePlacers, 'No word placers available');
Severity: Minor
Found in src/SixtyNine/Cloud/Command/CommandsHelper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'getFontSizeGenerator'.
Open

        Assert::oneOf($type, $this->fontSizeBoosts, 'Invalid font size boost: ' . $type);
Severity: Minor
Found in src/SixtyNine/Cloud/Command/CommandsHelper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'insertWords'.
Open

        Assert::true(null !== $file || null !== $url);
Severity: Minor
Found in src/SixtyNine/Cloud/Command/CommandsHelper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'setPlacer'.
Open

        Assert::oneOf($name, PlacerFactory::getInstance()->getPlacersNames(), 'Placer not found: ' . $name);
Severity: Minor
Found in src/SixtyNine/Cloud/Builder/CloudBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method renderCloud uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $this->drawer->drawText($pos[0], $pos[1], $word->getText(), $word->getSize(), $word->getColor(), $word->getAngle());
            }
Severity: Minor
Found in src/SixtyNine/Cloud/Renderer/CloudRenderer.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'addFont'.
Open

        Assert::fileExists($filename, 'The font file must exist');
Severity: Minor
Found in src/SixtyNine/Cloud/Factory/FontsFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getIsVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getIsVisible()
    {
        return $this->isVisible;
    }
Severity: Minor
Found in src/SixtyNine/Cloud/Model/CloudWord.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\Webmozart\Assert\Assert' in method '__construct'.
Open

        Assert::fileExists($file, "File not found $file");
Severity: Minor
Found in src/SixtyNine/Cloud/Model/Font.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language