sixty-nine/php-cloud-lib

View on GitHub

Showing 108 of 109 total issues

The method searchPlace() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    protected function searchPlace(Box $bounds, Box $box)
    {

        $this->logger->log('  Search place for ' . $box, Logger::DEBUG);

Severity: Minor
Found in src/SixtyNine/Cloud/Usher/Usher.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The variable $A is not named in camelCase.
Open

    public function getNextPlaceToTry(PointInterface $current)
    {
        $first = $this->getFirstPlaceToTry();
        // TODO: needs some params adjusting ($a, $b, $delta)
        $a = 50;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $B is not named in camelCase.
Open

    public function getNextPlaceToTry(PointInterface $current)
    {
        $first = $this->getFirstPlaceToTry();
        // TODO: needs some params adjusting ($a, $b, $delta)
        $a = 50;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $A is not named in camelCase.
Open

    public function getNextPlaceToTry(PointInterface $current)
    {
        $first = $this->getFirstPlaceToTry();
        // TODO: needs some params adjusting ($a, $b, $delta)
        $a = 50;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $B is not named in camelCase.
Open

    public function getNextPlaceToTry(PointInterface $current)
    {
        $first = $this->getFirstPlaceToTry();
        // TODO: needs some params adjusting ($a, $b, $delta)
        $a = 50;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $A is not named in camelCase.
Open

    public function getNextPlaceToTry(PointInterface $current)
    {
        $first = $this->getFirstPlaceToTry();
        // TODO: needs some params adjusting ($a, $b, $delta)
        $a = 50;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $B is not named in camelCase.
Open

    public function getNextPlaceToTry(PointInterface $current)
    {
        $first = $this->getFirstPlaceToTry();
        // TODO: needs some params adjusting ($a, $b, $delta)
        $a = 50;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

TODO found
Open

        // TODO: needs some params adjusting ($a, $b, $delta)
Severity
Category
Status
Source
Language