Sign upLogin

slack-ruby/slack-ruby-client

View on GitHub
Star
bin/commands/team_externalTeams.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        g.command 'list' do |c|
          c.flag 'connection_status_filter', desc: 'Status of the connected team.'
          c.flag 'cursor', desc: "Paginate through collections of data by setting parameter to the team_id attribute returned by a previous request's response_metadata. If not provided, the first page of the collection is returned. See pagination for more detail."
          c.flag 'limit', desc: 'The maximum number of items to return per page.'
          c.flag 'slack_connect_pref_filter', desc: 'Filters connected orgs by Slack Connect pref override(s). Value can be: approved_orgs_only allow_sc_file_uploads profile_visibility away_team_sc_invite_permissions accept_sc_invites sc_mpdm_to_private require_sc_channel_for_sc_dm external_awareness_context_bar.'
Severity: Major
Found in bin/commands/team_externalTeams.rb and 7 other locations - About 1 hr to fix
bin/commands/apps_datastore.rb on lines 90..99
bin/commands/bookmarks.rb on lines 11..20
bin/commands/conversations.rb on lines 74..83
bin/commands/files.rb on lines 66..75
bin/commands/files_remote.rb on lines 69..78
bin/commands/usergroups.rb on lines 59..68
bin/commands/users_admin.rb on lines 11..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status