Sign upLogin

socialcast/link_preview

View on GitHub
Star
lib/link_preview/parser.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Parser has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Parser
    attr_accessor :discovered_uris

    def initialize(config, options = {})
      @config = config
Severity: Minor
Found in lib/link_preview/parser.rb - About 3 hrs to fix

    Method valid_meta_node? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def valid_meta_node?(node)
      return false unless node
      return false unless node.respond_to?(:attributes)
      return false unless node.attributes['content']
      return false unless node.attributes['content'].value
    Severity: Minor
    Found in lib/link_preview/parser.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method matching_meta_pair? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def matching_meta_pair?(node, key, value)
      return false unless valid_meta_node?(node)
      return false unless node.attributes[key]
      return false unless node.attributes[key].value
      return false unless matching_meta_value?(node, key, value)
    Severity: Minor
    Found in lib/link_preview/parser.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status