soumya92/barista

View on GitHub

Showing 92 of 92 total issues

Function main has 382 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    material.Load(home("Github/material-design-icons"))
    mdi.Load(home("Github/MaterialDesign-Webfont"))
    typicons.Load(home("Github/typicons.font"))
    fontawesome.Load(home("Github/Font-Awesome"))
Severity: Major
Found in samples/sample-bar/sample-bar.go - About 1 day to fix

    Function main has 236 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func main() {
        material.Load(home("Github/material-design-icons"))
        mdi.Load(home("Github/MaterialDesign-Webfont"))
        typicons.Load(home("Github/typicons.font"))
        fontawesome.Load(home("Github/Font-Awesome"))
    Severity: Major
    Found in samples/simple/simple.go - About 1 day to fix

      Function main has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
      Open

      func main() {
          material.Load(home("Github/material-design-icons"))
          mdi.Load(home("Github/MaterialDesign-Webfont"))
          typicons.Load(home("Github/typicons.font"))
          fontawesome.Load(home("Github/Font-Awesome"))
      Severity: Minor
      Found in samples/sample-bar/sample-bar.go - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method SegmentGroup.Segments has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
      Open

      func (g *SegmentGroup) Segments() []*bar.Segment {
          var segments []*bar.Segment
          for _, o := range g.outputs {
              for _, s := range o.Segments() {
                  segments = append(segments, s.Clone())
      Severity: Minor
      Found in outputs/group.go - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Watcher.tryWatch has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
      Open

      func (w *Watcher) tryWatch(restarted bool) error {
          currentLvl := -1
          for lvl, p := range w.hierarchy {
              err := w.fswatcher.Add(p)
              if err == nil {
      Severity: Minor
      Found in base/watchers/file/file.go - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function main has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
      Open

      func main() {
          material.Load(home("Github/material-design-icons"))
          mdi.Load(home("Github/MaterialDesign-Webfont"))
          typicons.Load(home("Github/typicons.font"))
          fontawesome.Load(home("Github/Font-Awesome"))
      Severity: Minor
      Found in samples/simple/simple.go - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File sample-bar.go has 594 lines of code (exceeds 500 allowed). Consider refactoring.
      Open

      // Copyright 2017 Google Inc.
      //
      // Licensed under the Apache License, Version 2.0 (the "License");
      // you may not use this file except in compliance with the License.
      // You may obtain a copy of the License at
      Severity: Minor
      Found in samples/sample-bar/sample-bar.go - About 4 hrs to fix

        Segment has 29 methods (exceeds 20 allowed). Consider refactoring.
        Open

        func (s *Segment) Text(content string) *Segment {
            s.text = content
            s.pango = false
            return s
        }
        Severity: Minor
        Found in bar/segment.go - About 3 hrs to fix

          Function main has 108 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func main() {
              colors.LoadFromMap(map[string]string{
                  "good":     "#0f0",
                  "bad":      "#f00",
                  "degraded": "#ff0",
          Severity: Major
          Found in samples/i3status/i3status.go - About 3 hrs to fix

            Function main has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
            Open

            func main() {
                colors.LoadFromMap(map[string]string{
                    "good":     "#0f0",
                    "bad":      "#f00",
                    "degraded": "#ff0",
            Severity: Minor
            Found in samples/i3status/i3status.go - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (m *Module) Stream(s bar.Sink) {
                i, err := currentInfo.Get()
                nextInfo, done := currentInfo.Subscribe()
                defer done()
                outputFunc := m.outputFunc.Get().(func(Info) bar.Output)
            Severity: Major
            Found in modules/meminfo/meminfo.go and 1 other location - About 2 hrs to fix
            modules/sysinfo/sysinfo.go on lines 101..121

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 244.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (m *Module) Stream(s bar.Sink) {
                i, err := currentInfo.Get()
                nextInfo, done := currentInfo.Subscribe()
                defer done()
                outputFunc := m.outputFunc.Get().(func(Info) bar.Output)
            Severity: Major
            Found in modules/sysinfo/sysinfo.go and 1 other location - About 2 hrs to fix
            modules/meminfo/meminfo.go on lines 118..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 244.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (t *TimerModule) Stream(sink bar.Sink) {
                w := watchUnit(t.name + ".timer")
                defer w.Unsubscribe()
            
                w.FetchOnSignal(
            Severity: Major
            Found in modules/systemd/systemd.go and 1 other location - About 2 hrs to fix
            modules/systemd/systemd.go on lines 141..165

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 237.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (s *ServiceModule) Stream(sink bar.Sink) {
                w := watchUnit(s.name + ".service")
                defer w.Unsubscribe()
            
                w.FetchOnSignal(
            Severity: Major
            Found in modules/systemd/systemd.go and 1 other location - About 2 hrs to fix
            modules/systemd/systemd.go on lines 247..271

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 237.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method parse_args has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

            def parse_args(signature)
              in_fn_ptr = 0
              curr = ''
              args = []
              signature.each_char do |c|
            Severity: Minor
            Found in testing/capi/funcs.rb - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function main has 28 return statements (exceeds 4 allowed).
            Open

            func main() {
                material.Load(home("Github/material-design-icons"))
                mdi.Load(home("Github/MaterialDesign-Webfont"))
                typicons.Load(home("Github/typicons.font"))
                fontawesome.Load(home("Github/Font-Awesome"))
            Severity: Major
            Found in samples/sample-bar/sample-bar.go - About 2 hrs to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  ghNotify := github.New("%%GITHUB_CLIENT_ID%%", "%%GITHUB_CLIENT_SECRET%%").
                      Output(func(n github.Notifications) bar.Output {
                          if n.Total() == 0 {
                              return nil
                          }
              Severity: Major
              Found in samples/simple/simple.go and 1 other location - About 2 hrs to fix
              samples/sample-bar/sample-bar.go on lines 605..624

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 220.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  ghNotify := github.New("%%GITHUB_CLIENT_ID%%", "%%GITHUB_CLIENT_SECRET%%").
                      Output(func(n github.Notifications) bar.Output {
                          if n.Total() == 0 {
                              return nil
                          }
              Severity: Major
              Found in samples/sample-bar/sample-bar.go and 1 other location - About 2 hrs to fix
              samples/simple/simple.go on lines 415..434

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 220.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              alsaImpl has 21 methods (exceeds 20 allowed). Consider refactoring.
              Open

              type alsaImpl struct{}
              Severity: Minor
              Found in modules/volume/alsa/alsa_capi.go - About 2 hrs to fix

                Method write_test_file has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                def write_test_file(library, package, c_functions)
                  write_go_file("#{library}_capi_for_test.go") do |out|
                    out.puts "package #{package}"
                    out.puts(<<~PREAMBLE)
                      import "sync"
                Severity: Minor
                Found in testing/capi/generators.rb - About 2 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language