Sign upLogin

soumya92/barista

View on GitHub
Star
samples/sample-bar/sample-bar.go

Summary

Maintainability
F
3 days
Test Coverage

Function main has 382 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    material.Load(home("Github/material-design-icons"))
    mdi.Load(home("Github/MaterialDesign-Webfont"))
    typicons.Load(home("Github/typicons.font"))
    fontawesome.Load(home("Github/Font-Awesome"))
Severity: Major
Found in samples/sample-bar/sample-bar.go - About 1 day to fix

    Function main has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
    Open

    func main() {
    material.Load(home("Github/material-design-icons"))
    mdi.Load(home("Github/MaterialDesign-Webfont"))
    typicons.Load(home("Github/typicons.font"))
    fontawesome.Load(home("Github/Font-Awesome"))
    Severity: Minor
    Found in samples/sample-bar/sample-bar.go - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File sample-bar.go has 594 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    // Copyright 2017 Google Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
    Severity: Minor
    Found in samples/sample-bar/sample-bar.go - About 4 hrs to fix

      Function main has 28 return statements (exceeds 4 allowed).
      Open

      func main() {
    material.Load(home("Github/material-design-icons"))
    mdi.Load(home("Github/MaterialDesign-Webfont"))
    typicons.Load(home("Github/typicons.font"))
    fontawesome.Load(home("Github/Font-Awesome"))
      Severity: Major
      Found in samples/sample-bar/sample-bar.go - About 2 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            ghNotify := github.New("%%GITHUB_CLIENT_ID%%", "%%GITHUB_CLIENT_SECRET%%").
        Output(func(n github.Notifications) bar.Output {
            if n.Total() == 0 {
                return nil
            }
        Severity: Major
        Found in samples/sample-bar/sample-bar.go and 1 other location - About 2 hrs to fix
        samples/simple/simple.go on lines 415..434

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 220.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        func whereami() (lat float64, lng float64, err error) {
    resp, err := http.Get("https://freegeoip.app/json/")
    if err != nil {
        return 0, 0, err
    }
        Severity: Minor
        Found in samples/sample-bar/sample-bar.go and 1 other location - About 50 mins to fix
        samples/simple/simple.go on lines 121..132

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status