Sign upLogin

sounisi5011/semver-range-intersect

View on GitHub
Star
src/single-range.ts

Summary

Maintainability
F
4 days
Test Coverage

Function merge has a Cognitive Complexity of 88 (exceeds 5 allowed). Consider refactoring.
Open

    public merge(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
Severity: Minor
Found in src/single-range.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function merge has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public merge(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
Severity: Major
Found in src/single-range.ts - About 3 hrs to fix

    Function lowerBound has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                    const lowerBound = ((a, b) => {
                    const semverA: semver.SemVer | {} = a.semver;
                    const semverB: semver.SemVer | {} = b.semver;

                    // >2.0.0      / *           ... *
    Severity: Minor
    Found in src/single-range.ts - About 1 hr to fix

      Function intersect has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public intersect(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
      Severity: Minor
      Found in src/single-range.ts - About 1 hr to fix

        Function upperBound has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        const upperBound = ((a, b) => {
                    const semverA: semver.SemVer | {} = a.semver;
                    const semverB: semver.SemVer | {} = b.semver;

                    // <2.0.0      / *           ... *
        Severity: Minor
        Found in src/single-range.ts - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (isPrerelease(semverA)) {
                            return null;
                        }
          Severity: Major
          Found in src/single-range.ts - About 45 mins to fix

            Function intersect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public intersect(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
            Severity: Minor
            Found in src/single-range.ts - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                    if (isPrerelease(semverA)) {
                            return null;
                        }
            Severity: Major
            Found in src/single-range.ts - About 45 mins to fix

              Avoid too many return statements within this function.
              Open

                                      return null;
              Severity: Major
              Found in src/single-range.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                            return b;
                Severity: Major
                Found in src/single-range.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                              return a;
                  Severity: Major
                  Found in src/single-range.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                                return a;
                    Severity: Major
                    Found in src/single-range.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                              return null;
                      Severity: Major
                      Found in src/single-range.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                                    return a;
                        Severity: Major
                        Found in src/single-range.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                                      return a;
                          Severity: Major
                          Found in src/single-range.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                                        return b;
                            Severity: Major
                            Found in src/single-range.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                                          return b;
                              Severity: Major
                              Found in src/single-range.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                            return b;
                                Severity: Major
                                Found in src/single-range.ts - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                      if (a.operator === b.operator || semverCmp !== 0) {
                        // >2.0.0  / >3.0.0  ... >2.0.0
                        // >=1.0.0 / >=1.1.0 ... >=1.0.0
                        // >2.0.0  / >=2.0.1 ... >2.0.0
                        // >=2.0.1 / >2.0.0  ... >2.0.0
                                  Severity: Major
                                  Found in src/single-range.ts and 1 other location - About 2 hrs to fix
                                  src/single-range.ts on lines 217..237

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 87.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                      if (a.operator === b.operator || semverCmp !== 0) {
                        // <2.0.0  / <3.0.0  ... <3.0.0
                        // <=1.0.0 / <=1.1.0 ... <=1.1.0
                        // <2.0.0  / <=2.0.1 ... <=2.0.1
                        // <=2.0.1 / <2.0.0  ... <=2.0.1
                                  Severity: Major
                                  Found in src/single-range.ts and 1 other location - About 2 hrs to fix
                                  src/single-range.ts on lines 159..179

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 87.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status