sounisi5011/semver-range-intersect

src/utils.ts

Summary

Maintainability

F

4 days

Test Coverage

Function `getUpperBoundComparator` has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getUpperBoundComparator(
    comparatorList: readonly semver.Comparator[],
    options: { singleRange?: boolean } = {},
): semver.Comparator {
    const validComparatorList = comparatorList.filter(

Found in src/utils.ts - About 3 hrs to fix

Function `getLowerBoundComparator` has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getLowerBoundComparator(
    comparatorList: readonly semver.Comparator[],
    options: { singleRange?: boolean } = {},
): semver.Comparator {
    const validComparatorList = comparatorList.filter(

Found in src/utils.ts - About 3 hrs to fix

File `utils.ts` has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import semver from 'semver';

export function isNotNull<T>(value: T | null): value is T {
    return value !== null;
}

Found in src/utils.ts - About 2 hrs to fix

Avoid deeply nested control flow statements.
Open

                        if (semverCmpMain < 0) {
                            return new semver.Comparator(
                                `<${stripSemVerPrerelease(semverA)}`,
                                a.options,
                            );

Found in src/utils.ts - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        if (semverCmpMain > 0) {
                            return new semver.Comparator(
                                a.operator + stripSemVerPrerelease(semverA),
                                a.options,
                            );

Found in src/utils.ts - About 45 mins to fix

Avoid too many `return` statements within this function.
Open

                            return new semver.Comparator(
                                `<${stripSemVerPrerelease(semverA)}`,
                                a.options,
                            );

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return a;

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                            return new semver.Comparator(
                                a.operator + stripSemVerPrerelease(semverA),
                                a.options,
                            );

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return a;

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                            return new semver.Comparator(
                                b.operator + stripSemVerPrerelease(semverB),
                                b.options,
                            );

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return b;

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return a;

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return b;

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                            return new semver.Comparator(
                                `<${stripSemVerPrerelease(semverB)}`,
                                b.options,
                            );

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return b;

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return b;

Found in src/utils.ts - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

                    return a;

Found in src/utils.ts - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (!(semverA instanceof semver.SemVer)) {
                if (
                    !options.singleRange &&
                    isPrerelease(semverB) &&
                    !(

Found in src/utils.ts and 1 other location - About 1 day to fix

Read up
Read up

src/utils.ts on lines 149..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (!(semverA instanceof semver.SemVer)) {
                if (
                    !options.singleRange &&
                    isPrerelease(semverB) &&
                    !(

Found in src/utils.ts and 1 other location - About 1 day to fix

Read up
Read up

src/utils.ts on lines 262..296

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const validComparatorList = comparatorList.filter(
        comparator =>
            isValidOperator(comparator, ['<', '<=']) ||
            !(comparator.semver instanceof semver.SemVer),
    );

Found in src/utils.ts and 1 other location - About 30 mins to fix

Read up
Read up

src/utils.ts on lines 127..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const validComparatorList = comparatorList.filter(
        comparator =>
            isValidOperator(comparator, ['>', '>=']) ||
            !(comparator.semver instanceof semver.SemVer),
    );

Found in src/utils.ts and 1 other location - About 30 mins to fix

Read up
Read up

src/utils.ts on lines 240..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

There are no issues that match your filters.