Sign upLogin

sovereignbot/citadel

View on GitHub
Star

Showing 284 of 284 total issues

Avoid excessively long variable names like $corporationActiveArea. Keep variable name length under 20.
Open

        $corporationActiveArea = @$stats["corporationActiveArea"];
Severity: Minor
Found in src/Plugins/onMessage/char.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $corporationActiveArea. Keep variable name length under 20.
Open

        $corporationActiveArea = @$stats["corporationActiveArea"];
Severity: Minor
Found in src/Plugins/onMessage/corp.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/coinflip.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/pc.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/wolf.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/guilds.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/memory.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/about.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/char.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/time.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/config.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/help.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/tq.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/eightball.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/porn.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/user.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/corp.php - About 1 hr to fix

The class Sovereign has 17 fields. Consider redesigning Sovereign to keep the number of fields under 15.
Open

class Sovereign
{
    /**
     * @var WebSocket
     */
Severity: Minor
Found in src/Sovereign.php by phpmd

TooManyFields

Since: 0.1

Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

Example

class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

Source https://phpmd.org/rules/codesize.html#toomanyfields

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/auth.php - About 1 hr to fix

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/join.php - About 1 hr to fix
Severity
Category
Status
Source
Language