Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star

Showing 537 of 537 total issues

Method leave has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public void
  leave(Node node)
  {
    if (node instanceof Document) {
      leave((Document)node);
Severity: Minor
Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (isRealVisible) {
      //The element is visible, handle the xmlns definition
      Attr xmlns = element.getAttributeNodeNS(XMLNS_URI, XMLNS);
      Node n = null;
      if (xmlns == null) {
    Severity: Major
    Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java and 1 other location - About 1 hr to fix
    ext/java/nokogiri/internals/c14n/Canonicalizer11.java on lines 361..380

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (isRealVisible) {
      //The element is visible, handle the xmlns definition
      Attr xmlns = element.getAttributeNodeNS(XMLNS_URI, XMLNS);
      Node n = null;
      if (xmlns == null) {
    Severity: Major
    Found in ext/java/nokogiri/internals/c14n/Canonicalizer11.java and 1 other location - About 1 hr to fix
    ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java on lines 326..345

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method isEqualNode has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public boolean
  isEqualNode(Node arg)
  {
    if (arg == this) {
      return true;
    Severity: Minor
    Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTMdefaultNamespaceDeclarationNode.java - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          void
    push(int level)
    {
      currentLevel = level;
      if (currentLevel == -1) {
      Severity: Major
      Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java and 1 other location - About 1 hr to fix
      ext/java/nokogiri/internals/c14n/Canonicalizer11.java on lines 69..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          void
    push(int level)
    {
      currentLevel = level;
      if (currentLevel == -1) {
      Severity: Major
      Found in ext/java/nokogiri/internals/c14n/Canonicalizer11.java and 1 other location - About 1 hr to fix
      ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java on lines 65..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method getXmlnsAttr has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          void
    getXmlnsAttr(Collection<Attr> col)
    {
      int size = levels.size() - 1;
      if (cur == null) {
      Severity: Minor
      Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_sibling has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

            def add_sibling(next_or_previous, node_or_tags)
        raise("Cannot add sibling to a node with no parent") unless parent

        impl = next_or_previous == :next ? :add_next_sibling_node : :add_previous_sibling_node
        iter = next_or_previous == :next ? :reverse_each : :each
      Severity: Minor
      Found in lib/nokogiri/xml/node.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method method_missing has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

              def method_missing(method, *args, &block)
          opts = args.last.is_a?(Hash) ? args.pop : {}
          case method.to_s
          when /^(.*)!$/
            @node["id"] = Regexp.last_match(1)
      Severity: Minor
      Found in lib/nokogiri/xml/builder.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method write_to has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

            def write_to(io, *options)
        return super unless document.is_a?(HTML5::Document)

        options = options.first.is_a?(Hash) ? options.shift : {}
        encoding = options[:encoding] || options[0]
      Severity: Minor
      Found in lib/nokogiri/html5/node.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method protectAgainstWrappingAttack has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public static boolean
  protectAgainstWrappingAttack(Node startNode, String value)
  {
    Node startParent = startNode.getParentNode();
    Node processedNode;
      Severity: Minor
      Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 1 hr to fix

        Method outputAttrToWriter has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          protected static final void
  outputAttrToWriter(
    final String name, final String value,
    final OutputStream writer, final Map<String, byte[]> cache
  ) throws IOException
        Severity: Minor
        Found in ext/java/nokogiri/internals/c14n/CanonicalizerBase.java - About 1 hr to fix

          Method in_context has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            @JRubyMethod(required = 2, visibility = Visibility.PRIVATE)
  public IRubyObject
  in_context(ThreadContext context, IRubyObject str, IRubyObject options)
  {
    RubyClass klass;
          Severity: Minor
          Found in ext/java/nokogiri/XmlNode.java - About 1 hr to fix

            Method extractDecls has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              protected IRubyObject[]
  extractDecls(ThreadContext context, Node node)
  {
    List<IRubyObject> decls = new ArrayList<IRubyObject>();
    while (node != null) {
            Severity: Minor
            Found in ext/java/nokogiri/XmlDtd.java - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                @JRubyMethod
  public IRubyObject
  create_external_subset(ThreadContext context,
                         IRubyObject name,
                         IRubyObject external_id,
              Severity: Major
              Found in ext/java/nokogiri/XmlNode.java and 1 other location - About 1 hr to fix
              ext/java/nokogiri/XmlNode.java on lines 1055..1077

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 101.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                @JRubyMethod
  public IRubyObject
  create_internal_subset(ThreadContext context,
                         IRubyObject name,
                         IRubyObject external_id,
              Severity: Major
              Found in ext/java/nokogiri/XmlNode.java and 1 other location - About 1 hr to fix
              ext/java/nokogiri/XmlNode.java on lines 1095..1114

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 101.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (c > 0x07FF) {
      ch = (char)(c >>> 12);
      write = 0xE0;
      if (ch > 0) {
        write |= (ch & 0x0F);
              Severity: Major
              Found in ext/java/nokogiri/internals/c14n/UtfHelper.java and 1 other location - About 1 hr to fix
              ext/java/nokogiri/internals/c14n/UtfHelper.java on lines 110..122

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 100.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (c > 0x07FF) {
        ch = (char)(c >>> 12);
        write = 0xE0;
        if (ch > 0) {
          write |= (ch & 0x0F);
              Severity: Major
              Found in ext/java/nokogiri/internals/c14n/UtfHelper.java and 1 other location - About 1 hr to fix
              ext/java/nokogiri/internals/c14n/UtfHelper.java on lines 65..77

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 100.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method parse_with has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                @JRubyMethod
  public IRubyObject
  parse_with(ThreadContext context, IRubyObject handlerRuby)
  {
    final Ruby runtime = context.getRuntime();
              Severity: Minor
              Found in ext/java/nokogiri/XmlSaxParserContext.java - About 1 hr to fix

                Method writeStringToUtf8 has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  public static void
  writeStringToUtf8(
    final String str,
    final OutputStream out
  ) throws IOException
                Severity: Minor
                Found in ext/java/nokogiri/internals/c14n/UtfHelper.java - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language