Sign upLogin

speedworks/speedy

View on GitHub
Star
Core/Middleware/Auth.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function Authorize has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function Authorize($authType, $redirectTo=null)
    {
        $auth = new BaseAuth();
        if($authType == "session")
        {
Severity: Minor
Found in Core/Middleware/Auth.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Authenticate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function Authenticate()
    {
        $auth = new BaseAuth();
        if($this->type == "KEY")
        {
Severity: Minor
Found in Core/Middleware/Auth.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Authorize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function Authorize($authType, $redirectTo=null)
    {
        $auth = new BaseAuth();
        if($authType == "session")
        {
Severity: Minor
Found in Core/Middleware/Auth.php - About 1 hr to fix

    Method Authenticate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function Authenticate()
    {
        $auth = new BaseAuth();
        if($this->type == "KEY")
        {
    Severity: Minor
    Found in Core/Middleware/Auth.php - About 1 hr to fix

      The method Authenticate is not named in camelCase.
      Open

          public function Authenticate()
    {
        $auth = new BaseAuth();
        if($this->type == "KEY")
        {
      Severity: Minor
      Found in Core/Middleware/Auth.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method Credentials is not named in camelCase.
      Open

          public static function Credentials($userName, $password)
    {
        $auth = new Auth("CREDENTIALS",$userName,$password);
        return $auth;
    }
      Severity: Minor
      Found in Core/Middleware/Auth.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method Checksum is not named in camelCase.
      Open

          public static function Checksum()
    {
        $auth = new Auth("CHECKSUM");
        return $auth;
    }
      Severity: Minor
      Found in Core/Middleware/Auth.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method Key is not named in camelCase.
      Open

          public static function Key()
    {
        $auth = new Auth("KEY");
        return $auth;
    }
      Severity: Minor
      Found in Core/Middleware/Auth.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method Authorize is not named in camelCase.
      Open

          public function Authorize($authType, $redirectTo=null)
    {
        $auth = new BaseAuth();
        if($authType == "session")
        {
      Severity: Minor
      Found in Core/Middleware/Auth.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status