speedworks/speedy

View on GitHub
public/index.php

Summary

Maintainability
A
3 hrs
Test Coverage

ExceptionHandler accesses the super-global variable $_ENV.
Open

function ExceptionHandler($exception)
{
    header("HTTP/1.0 500 Server Error");
    if($_ENV['debug'] == true)
    {
Severity: Minor
Found in public/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

loadConfig accesses the super-global variable $_ENV.
Open

function loadConfig()
{
    $config = require_once __DIR__ . '/../App/config.php';
    foreach ($config as $key => $value) {
        $_ENV[$key] = $value;
Severity: Minor
Found in public/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

ErrorHandler accesses the super-global variable $_ENV.
Open

function ErrorHandler($errno, $errstr, $errfile, $errline)
{
    if (!(error_reporting() & $errno))
    {
        return;
Severity: Minor
Found in public/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method ErrorHandler has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ErrorHandler($errno, $errstr, $errfile, $errline)
{
    if (!(error_reporting() & $errno))
    {
        return;
Severity: Major
Found in public/index.php - About 3 hrs to fix

    Function ErrorHandler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function ErrorHandler($errno, $errstr, $errfile, $errline)
    {
        if (!(error_reporting() & $errno))
        {
            return;
    Severity: Minor
    Found in public/index.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The function ErrorHandler() contains an exit expression.
    Open

        die;
    Severity: Minor
    Found in public/index.php by phpmd

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
        public function bar($param)  {
            if ($param === 42) {
                exit(23);
            }
        }
    }

    Source https://phpmd.org/rules/design.html#exitexpression

    There are no issues that match your filters.

    Category
    Status