Sign upLogin

squirrelphp/entities

View on GitHub
Star

Showing 59 of 59 total issues

Method buildSelectQueryFreeform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildSelectQueryFreeform(array $options): array
    {
        // Process options and make sure all values are valid
        [
            $sanitizedOptions,
Severity: Minor
Found in src/MultiRepositoryReadOnly.php - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

namespace Squirrel\Entities\Builder;

use Squirrel\Entities\RepositoryReadOnlyInterface;
    Severity: Major
    Found in src/Builder/SelectIterator.php and 1 other location - About 1 hr to fix
    src/Builder/MultiSelectIterator.php on lines 1..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

namespace Squirrel\Entities\Builder;

use Squirrel\Entities\MultiRepositoryReadOnlyInterface;
    Severity: Major
    Found in src/Builder/MultiSelectIterator.php and 1 other location - About 1 hr to fix
    src/Builder/SelectIterator.php on lines 1..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            private string $connectionName,
        private string $tableName,
        /** Conversion from table to object fields */
        private array $tableToObjectFields,
        /** Conversion from object to table fields */
    Severity: Major
    Found in src/RepositoryConfig.php - About 1 hr to fix

      Function buildSelectQueryStructured has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function buildSelectQueryStructured(array $query): array
    {
        // Process options and make sure all values are valid
        [
            $sanitizedOptions,
      Severity: Minor
      Found in src/MultiRepositoryReadOnly.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildFieldSelection has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              array $selectOptions,
        array $objectToTableFields,
        array $objectTypes,
        array $objectTypesNullable,
        bool $generateSql = false,
      Severity: Minor
      Found in src/MultiRepositoryReadOnly.php - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else { // Variables are contained in SQL
                // Cast change values - can be scalar or array
                $fieldValue = $this->castTableVariable($fieldValue);

                // Convert all :variable: values from object to table notation
        Severity: Minor
        Found in src/RepositoryWriteable.php and 1 other location - About 35 mins to fix
        src/RepositoryReadOnly.php on lines 458..480

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        try {
                    $baseRepositoryReflection = new \ReflectionClass($repository);
                    $baseRepositoryPropertyReflection = $baseRepositoryReflection->getProperty('db');
                    $baseRepositoryPropertyReflection->setAccessible(true);
                    $foundConnection = $baseRepositoryPropertyReflection->getValue($repository);
        Severity: Minor
        Found in src/Transaction.php and 1 other location - About 35 mins to fix
        src/Transaction.php on lines 37..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        try {
                    $builderRepositoryReflection = new \ReflectionClass($repository);
                    $builderRepositoryPropertyReflection = $builderRepositoryReflection->getProperty('repository');
                    $builderRepositoryPropertyReflection->setAccessible(true);
                    $repository = $builderRepositoryPropertyReflection->getValue($repository);
        Severity: Minor
        Found in src/Transaction.php and 1 other location - About 35 mins to fix
        src/Transaction.php on lines 54..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (\strpos($whereName, ':') !== false) {
                // Cast variable values
                $whereValue = $this->castTableVariable($whereValue);

                // Convert all :variable values from object to table notation
        Severity: Minor
        Found in src/RepositoryReadOnly.php and 1 other location - About 35 mins to fix
        src/RepositoryWriteable.php on lines 78..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function convertResultToObject has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function convertResultToObject(array $tableResult): object
    {
        // Only create reflection class once we need it, to be resource efficient
        if (!isset($this->reflectionClass)) {
            /**
        Severity: Minor
        Found in src/RepositoryReadOnly.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return new LargeObject(\strval($value));
        Severity: Major
        Found in src/RepositoryReadOnly.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return \boolval($value) === true ? 1 : 0;
          Severity: Major
          Found in src/RepositoryReadOnly.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return \strval($value);
            Severity: Major
            Found in src/RepositoryReadOnly.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return Coerce::toString($value);
              Severity: Major
              Found in src/RepositoryReadOnly.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return \floatval($value);
                Severity: Major
                Found in src/RepositoryReadOnly.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return \intval($value);
                  Severity: Major
                  Found in src/RepositoryReadOnly.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return Coerce::toFloat($value);
                    Severity: Major
                    Found in src/RepositoryReadOnly.php - About 30 mins to fix

                      Function insertOrUpdate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function insertOrUpdate(array $fields, array $indexFields = [], ?array $updateFields = null): void
    {
        // Fields after conversion to table notation
        $actualIndexFields = [];
                      Severity: Minor
                      Found in src/RepositoryWriteable.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language