squirrly/squirrly-seo

View on GitHub
classes/SQ_Ranking.php

Summary

Maintainability
D
1 day
Test Coverage

File SQ_Ranking.php has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Class for Google Ranking Record
 */
Severity: Minor
Found in classes/SQ_Ranking.php - About 2 hrs to fix

    Function getOtherKeywords has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getOtherKeywords($post_id) {
            global $wpdb;
            $other_keywords = array();
            $sql = "SELECT count(kw.`keyword`) as searched, kw.`keyword`
                           FROM `" . $this->keyword_table . "` kw
    Severity: Minor
    Found in classes/SQ_Ranking.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getOtherKeywords has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getOtherKeywords($post_id) {
            global $wpdb;
            $other_keywords = array();
            $sql = "SELECT count(kw.`keyword`) as searched, kw.`keyword`
                           FROM `" . $this->keyword_table . "` kw
    Severity: Minor
    Found in classes/SQ_Ranking.php - About 1 hr to fix

      Function processRanking has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function processRanking(&$return, $post_id) {
              if (isset($return->seo) && is_object($return->seo)) {
                  $return->global_rank = $this->findTodayRank($post_id, 'global_rank');
                  $saved_keyword = $this->findTodayRank($post_id, 'keyword');
      
      Severity: Minor
      Found in classes/SQ_Ranking.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getGoogleRank has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          function getGoogleRank($post_id = 0, $keyword = "", $country = "com", $language = "en") {
              global $wpdb;
              $this->keyword = $keyword;
      
              $keyword = str_replace(" ", "+", urlencode(strtolower($keyword)));
      Severity: Minor
      Found in classes/SQ_Ranking.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getGoogleExtension has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function getGoogleExtension($language) {
              switch ($language) {
                  case 'en':
                      $country = '';
                      break;
      Severity: Minor
      Found in classes/SQ_Ranking.php - About 1 hr to fix

        Method getRank has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getRank($post_id = "") {
                global $wpdb;
        
                //Check if ranks is saved in database
                $sql = "SELECT analytics.`id`,analytics.`indexed`,analytics.`global_rank`,analytics.`local_rank`, analytics.`keyword`,analytics.`other_keywords`,analytics.`date`
        Severity: Minor
        Found in classes/SQ_Ranking.php - About 1 hr to fix

          Method getGoogleRank has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function getGoogleRank($post_id = 0, $keyword = "", $country = "com", $language = "en") {
                  global $wpdb;
                  $this->keyword = $keyword;
          
                  $keyword = str_replace(" ", "+", urlencode(strtolower($keyword)));
          Severity: Minor
          Found in classes/SQ_Ranking.php - About 1 hr to fix

            Function checkIndexed has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function checkIndexed(&$return, $post_id) {
                    $return->indexed = $this->findHistoryIndexed($post_id);
            
                    //If is indexed search is a keyword is indexed
                    if ($return->indexed == 1) {
            Severity: Minor
            Found in classes/SQ_Ranking.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return 0;
            Severity: Major
            Found in classes/SQ_Ranking.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (!isset($other_keywords[$row->keyword]['local']) || $other_keywords[$row->keyword]['local'] == 0) {
                                  $row->local_rank = $this->getGoogleRank($post_id, $row->keyword);
                                  if ($row->local_rank > 0) {
                                      //Save results
                                      $this->saveOtherRank($post_id, $row->global_rank, 'local', $row->keyword);
              Severity: Minor
              Found in classes/SQ_Ranking.php and 1 other location - About 30 mins to fix
              classes/SQ_Ranking.php on lines 100..106

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (!isset($other_keywords[$row->keyword]['global']) || $other_keywords[$row->keyword]['global'] == 0) {
                              $row->global_rank = $this->getGoogleRank($post_id, $row->keyword);
                              if ($row->global_rank > 0) {
                                  //Save results
                                  $this->saveOtherRank($post_id, $row->global_rank, 'global', $row->keyword);
              Severity: Minor
              Found in classes/SQ_Ranking.php and 1 other location - About 30 mins to fix
              classes/SQ_Ranking.php on lines 110..116

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status