squirrly/squirrly-seo

View on GitHub
controllers/SQ_Post.php

Summary

Maintainability
C
1 day
Test Coverage

Function checkImage has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    function checkImage($post_id) {
        @set_time_limit(90);
        $local_file = false;

        $content = stripslashes(SQ_Tools::getValue('post_content'));
Severity: Minor
Found in controllers/SQ_Post.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkImage has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function checkImage($post_id) {
        @set_time_limit(90);
        $local_file = false;

        $content = stripslashes(SQ_Tools::getValue('post_content'));
Severity: Major
Found in controllers/SQ_Post.php - About 2 hrs to fix

    Function hookSavePost has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        function hookSavePost($post_id) {
            $file_name = false;
    
    
            // unhook this function so it doesn't loop infinitely
    Severity: Minor
    Found in controllers/SQ_Post.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                                if (!in_array($row, $urls)) {
                                    $urls[] = $row;
                                }
    Severity: Major
    Found in controllers/SQ_Post.php - About 45 mins to fix

      Function checkAdvMeta has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function checkAdvMeta($post_id) {
              $meta = array();
              if (SQ_Tools::getIsset('sq_fp_title') || SQ_Tools::getIsset('sq_fp_description') || SQ_Tools::getIsset('sq_fp_keywords')) {
                  if (SQ_Tools::getIsset('sq_fp_title'))
                      $meta[] = array('key' => 'sq_fp_title',
      Severity: Minor
      Found in controllers/SQ_Post.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

              if ((SQ_Tools::getValue('action')) == 'editpost' &&
                      wp_is_post_revision($post_id) == '' &&
                      wp_is_post_autosave($post_id) == '' &&
                      get_post_status($post_id) != 'auto-draft' &&
                      get_post_status($post_id) != 'inherit' &&
      Severity: Major
      Found in controllers/SQ_Post.php - About 40 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            function getPaged($link) {
                $page = get_query_var('paged');
                if ($page && $page > 1) {
                    $link = trailingslashit($link) . "page/" . "$page";
                    if ($has_ut) {
        Severity: Major
        Found in controllers/SQ_Post.php and 2 other locations - About 40 mins to fix
        controllers/SQ_PostsList.php on lines 378..389
        models/SQ_Frontend.php on lines 1089..1100

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status