Method action
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
function action() {
$start = 0;
$nbr = 8;
$exclude = array();
Function action
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
function action() {
$start = 0;
$nbr = 8;
$exclude = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
echo '<script type="text/javascript">
var __date = "' . __('date', _PLUGIN_NAME_) . '"; var __readit = "' . __('Read it!', _PLUGIN_NAME_) . '"; var __insertit = "' . __('Insert it!', _PLUGIN_NAME_) . '"; var __reference = "' . __('Reference', _PLUGIN_NAME_) . '"; var __insertasbox = "' . __('Insert as box', _PLUGIN_NAME_) . '"; var __notrelevant = "' . __('Not relevant?', _PLUGIN_NAME_) . '"; var __insertparagraph = "' . __('Insert in your article', _PLUGIN_NAME_) . '"; var __tinymceerror = "' . __('For Squirrly to work, you have to have tinymce editor installed!', _PLUGIN_NAME_) . '"; var __ajaxerror = "' . __(':( I lost my squirrel. Please reload the page.', _PLUGIN_NAME_) . '"; var __nofound = "' . __('No results found!', _PLUGIN_NAME_) . '"; var __tinymceinactive = "' . __('Switch to Visual editor!', _PLUGIN_NAME_) . '"; var __morewords = "' . __('Use more words in one keyword', _PLUGIN_NAME_) . '"; var __toolong = "' . __('Takes too long to check this keyword ...', _PLUGIN_NAME_) . '"; var __doresearch = "' . __('Do a research!', _PLUGIN_NAME_) . '"; var __morekeywords = "' . __('Do more research!', _PLUGIN_NAME_) . '"; var __sq_photo_copyright = "' . __('[ ATTRIBUTE: Please check: %s to find out how to attribute this image ]', _PLUGIN_NAME_) . '"; var __has_attributes = "' . __('Has creative commons attributes', _PLUGIN_NAME_) . '"; var __no_attributes = "' . __('No known copyright restrictions', _PLUGIN_NAME_) . '";
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 296.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76