Sign upLogin

ssplatt/the_dw

View on GitHub
Star
app/controllers/lineups_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method show has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    @lineup = Lineup.find(params[:id])
    @nfl = NFLApi.new
    @weekstats = @nfl.get_players_stats({:statType => "weekStats",:season => @lineup.team.league.season, :week => @lineup.week})["players"]
Severity: Minor
Found in app/controllers/lineups_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calc_score has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def calc_score(player_week_stats)
      score = 0
      
      player_week_stats["stats"].each do |k,v|
        case k
Severity: Minor
Found in app/controllers/lineups_controller.rb - About 1 hr to fix

    Method selected_players has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def selected_players
      @selected_players = []
      lus = current_team.lineups.where.not(id: @lineup.id)
      lus.each do |p|
        if p.qb_id
    Severity: Minor
    Found in app/controllers/lineups_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status