Sign upLogin

steeffeen/FancyManiaLinks

View on GitHub
Star

Showing 2,233 of 2,233 total issues

The 'getScoretableVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getScoretableVisible()
    {
        return $this->scoretableVisible;
    }
Severity: Minor
Found in FML/CustomUI.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Components\CheckBoxDesign' in method '__construct'.
Open

        $this->setEnabledDesign(CheckBoxDesign::defaultDesign());
Severity: Minor
Found in FML/Script/Features/CheckBoxFeature.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getChallengeInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getChallengeInfoVisible()
    {
        return $this->challengeInfoVisible;
    }
Severity: Minor
Found in FML/CustomUI.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getNoticeVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getNoticeVisible()
    {
        return $this->noticeVisible;
    }
Severity: Minor
Found in FML/CustomUI.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

        $actionName = Builder::escapeText($this->actionName);
Severity: Minor
Found in FML/Script/Features/ActionTrigger.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Components\CheckBoxDesign' in method '__construct'.
Open

        $this->setDisabledDesign(CheckBoxDesign::defaultDesign());
Severity: Minor
Found in FML/Script/Features/CheckBoxFeature.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getGlobalVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getGlobalVisible()
    {
        return $this->globalVisible;
    }
Severity: Minor
Found in FML/CustomUI.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getShowSeconds()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getShowSeconds()
    {
        return $this->showSeconds;
    }
Severity: Minor
Found in FML/Script/Features/Clock.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getChatVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getChatVisible()
    {
        return $this->chatVisible;
    }
Severity: Minor
Found in FML/CustomUI.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

        $graphId    = Builder::escapeText($this->graph->getId(), false);
Severity: Minor
Found in FML/Script/Features/GraphCurve.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'getOnInitScriptText'.
Open

            $maximumCoordinatesValue = Builder::getVec2($this->maximumCoordinates);
Severity: Minor
Found in FML/Script/Features/GraphSettings.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method render uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $ipElement = $domDocument->createElement("ip", $this->ip . ":" . $this->port);
            $domElement->appendChild($ipElement);
        }
Severity: Minor
Found in FML/ManiaCode/JoinServer.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\FML\Script\Builder' in method 'getPagesArrayText'.
Open

        return Builder::getArray($pages, true);
Severity: Minor
Found in FML/Script/Features/Paging.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getDisableConfirmation()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getDisableConfirmation()
    {
        return $this->disableConfirmation;
    }
Severity: Minor
Found in FML/ManiaCode.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

            $controlId  = Builder::escapeText($this->control->getId());
Severity: Minor
Found in FML/Script/Features/ActionTrigger.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'buildScriptText'.
Open

        $controlId  = Builder::escapeText($this->control->getId());
Severity: Minor
Found in FML/Script/Features/ControlScript.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

            $pointVec2  = Builder::getVec2($point);
Severity: Minor
Found in FML/Script/Features/GraphCurve.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method setEntry uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (isset($this->entries[$language][$entryId])) {
                unset($this->entries[$language][$entryId]);
            }
        }
Severity: Minor
Found in FML/Elements/Dico.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\FML\Script\Builder' in method 'getEntrySubmitScriptText'.
Open

        $link      = Builder::escapeText($url . $entryName . "=");
Severity: Minor
Found in FML/Script/Features/EntrySubmit.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getScriptText uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // Other
            $scriptText = "
TriggerPageAction({$actionName});";
        }
Severity: Minor
Found in FML/Script/Features/ActionTrigger.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language