Sign upLogin

steeffeen/FancyManiaLinks

View on GitHub
Star

Showing 2,233 of 2,233 total issues

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

        $toggledControlId  = Builder::escapeText($this->toggledControl->getId());
Severity: Minor
Found in FML/Script/Features/Toggle.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method getOnInitScriptText uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $scriptText = "declare ToggleInterfaceControl <=> Page.MainFrame;";
        }
Severity: Minor
Found in FML/Script/Features/ToggleInterface.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\FML\Script\Builder' in method 'getPageButtonsArrayText'.
Open

        return Builder::getArray($pageButtons, true);
Severity: Minor
Found in FML/Script/Features/Paging.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getRememberState()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getRememberState()
    {
        return $this->rememberState;
    }
Severity: Minor
Found in FML/Script/Features/ToggleInterface.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Script\Builder' in method 'getKeyPressScriptText'.
Open

            $keyValue    = Builder::getText($this->keyName);
Severity: Minor
Found in FML/Script/Features/ToggleInterface.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

        $togglingControlId = Builder::escapeText($this->togglingControl->getId());
Severity: Minor
Found in FML/Script/Features/Toggle.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getOnlyShow()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getOnlyShow()
    {
        return $this->onlyShow;
    }
Severity: Minor
Found in FML/Script/Features/Toggle.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Script\Builder' in method 'getOnInitScriptText'.
Open

            $controlId  = Builder::escapeText($this->control->getId());
Severity: Minor
Found in FML/Script/Features/ToggleInterface.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'prepareRadioButtonIdsConstant'.
Open

            $radioButtonIds[$radioButton->getName()] = Builder::getId($radioButton->getQuad());
Severity: Minor
Found in FML/Script/Features/RadioButtonGroupFeature.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getOnlyHide()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getOnlyHide()
    {
        return $this->onlyHide;
    }
Severity: Minor
Found in FML/Script/Features/Toggle.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Script\Builder' in method 'prepareRadioButtonClickScript'.
Open

    declare RadioButtonGroupEntry <=> (Page.GetFirstChild(\"" . Builder::getId($this->entry) . "\") as CMlEntry);
Severity: Minor
Found in FML/Script/Features/RadioButtonGroupFeature.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

            $controlId = Builder::escapeText($this->control->getId());
Severity: Minor
Found in FML/Script/Features/PlayerProfile.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'getPageButtonsArrayText'.
Open

            return Builder::getArray(array('' => 0), true);
Severity: Minor
Found in FML/Script/Features/Paging.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Constant PhaseChange should be defined in uppercase
Open

    const PhaseChange      = "PhaseChange";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant EndMatch should be defined in uppercase
Open

    const EndMatch         = "EndMatch";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant VAR_LastTick should be defined in uppercase
Open

    const VAR_LastTick    = "FML_LastTick";
Severity: Minor
Found in FML/Script/Script.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Custom4 should be defined in uppercase
Open

    const Custom4          = "Custom4";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Silence should be defined in uppercase
Open

    const Silence          = "Silence";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Checkpoint should be defined in uppercase
Open

    const Checkpoint       = "Checkpoint";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Finish should be defined in uppercase
Open

    const Finish           = "Finish";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Severity
Category
Status
Source
Language