Sign upLogin

stefan-kolb/nucleus

View on GitHub
Star

Showing 116 of 116 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def initialize(hash = nil)
      super(hash)
      @endpoints = []
      return if hash.nil?
Severity: Minor
Found in lib/nucleus/core/models/provider.rb and 1 other location - About 35 mins to fix
lib/nucleus/core/models/vendor.rb on lines 13..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return this.renderer.listitem(body);
Severity: Major
Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return this.renderer.blockquote(body);
    Severity: Major
    Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return Parser.parse(Lexer.lex(src, opt), opt);
      Severity: Major
      Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return '<p>An error occured:</p><pre>'
        + escape(e.message + '', true)
        + '</pre>';
        Severity: Major
        Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return this.renderer.html(html);
          Severity: Major
          Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return this.renderer.paragraph(this.parseText());
            Severity: Major
            Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return :idle if gear_groups[0][:gears].all? { |gear| gear[:state] == 'idle' }
              Severity: Major
              Found in lib/nucleus/adapters/v1/openshift_v2/app_states.rb - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return this.renderer.table(header, body);
                Severity: Major
                Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return this.renderer.listitem(body);
                  Severity: Major
                  Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return this.renderer.list(body, ordered);
                    Severity: Major
                    Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return this.renderer.paragraph(this.inline.output(this.token.text));
                      Severity: Major
                      Found in public/swagger-ui/lib/marked.js - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return Enums::ApplicationStates::IDLE if dynos_idle?(dynos)
                        Severity: Major
                        Found in lib/nucleus/adapters/v1/heroku/app_states.rb - About 30 mins to fix

                          Method link_resource has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                                  def link_resource(namespaces = nil, instance_or_id = nil)
          namespaces = [] if namespaces.nil?
          id = ''
          if instance_or_id.respond_to?('id')
            id = instance_or_id.id unless instance_or_id.id.nil?
                          Severity: Minor
                          Found in lib/nucleus_api/api/entities/abstract_entity.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                    def retrieve_region(application)
            return unless application.key?(:region)
            found_region = native_region(application[:region])
            if found_region.nil?
              raise Errors::SemanticAdapterRequestError,
                          Severity: Minor
                          Found in lib/nucleus/adapters/v1/heroku/regions.rb and 1 other location - About 25 mins to fix
                          lib/nucleus/adapters/v1/openshift_v2/regions.rb on lines 28..35

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 30.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Method open_db has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def open_db
        db_backend = chosen_db_backend

        unless allowed_backends.key?(db_backend)
          raise StandardError,
                          Severity: Minor
                          Found in lib/nucleus_api/persistence/store.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method create_application has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                                    def create_application(application)
            # updates the application with a valid region identity
            retrieve_region(application)

            # Heroku does not support autoscale
                          Severity: Minor
                          Found in lib/nucleus/adapters/v1/heroku/application.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method requirements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def self.requirements(api_version)
      return @requirements[api_version] unless @requirements.nil? || @requirements[api_version].nil?
      # this is not the schema, but the requirements file (!)
      api_requirements_file = "#{Nucleus::API.src}/api/versions/#{api_version}/requirements.yml"
      schema_file = 'schemas/api.requirements.schema.yml'
                          Severity: Minor
                          Found in lib/nucleus_api/import/api_requirements.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                    def retrieve_region(application)
            return unless application.key?(:region)
            found_region = native_region(application[:region])
            if found_region.nil?
              raise Errors::SemanticAdapterRequestError,
                          Severity: Minor
                          Found in lib/nucleus/adapters/v1/openshift_v2/regions.rb and 1 other location - About 25 mins to fix
                          lib/nucleus/adapters/v1/heroku/regions.rb on lines 28..35

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 30.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Method zip has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def zip(path)
      string_io = Zip::OutputStream.write_buffer do |zio|
        Find.find(path) do |file|
          # do not process directories && do not include the Git DB files
          next if File.directory?(file) || (@exclude_git && file.start_with?("#{path}/.git"))
                          Severity: Minor
                          Found in lib/nucleus/core/common/files/archiver.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language