Sign upLogin

stellar/xdrgen

View on GitHub
Star

Showing 134 of 134 total issues

Method render_union has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def render_union(out, union)
        out.puts "define_type(\"#{name union}\", Union,"
        out.indent do
          out.puts "switch_type: #{type_reference union.discriminant.type},"
          out.puts "switch_name: :#{member_name union.discriminant},"
Severity: Minor
Found in lib/xdrgen/generators/elixir.rb - About 1 hr to fix

    Method encode_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def encode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
    Severity: Minor
    Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

      Method decode_innervalue_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def decode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
      Severity: Minor
      Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

        Method decode_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def decode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
        Severity: Minor
        Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

          Method encode_innervalue_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def encode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
          Severity: Minor
          Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

            Method encode_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def encode_member(member, out)
        case member.declaration
          when AST::Declarations::Void
            return
        end
            Severity: Minor
            Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

              Method render_enum has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def render_enum(enum, out)
        out.balance_after /,[\s]*/ do
          enum.members.each_with_index do |em, index|
            out.puts "#{em.name}(#{em.value})#{index == enum.members.size - 1 ? ';' : ','}"
          end
              Severity: Minor
              Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          case arm
            when AST::Definitions::UnionDefaultArm ;
              out.puts "default:"
            else
              arm.cases.each do |kase|
                Severity: Major
                Found in lib/xdrgen/generators/java.rb and 1 other location - About 1 hr to fix
                lib/xdrgen/generators/java.rb on lines 349..362

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          case arm
            when AST::Definitions::UnionDefaultArm ;
              out.puts "default:"
            else
              arm.cases.each do |kase|
                Severity: Major
                Found in lib/xdrgen/generators/java.rb and 1 other location - About 1 hr to fix
                lib/xdrgen/generators/java.rb on lines 310..323

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method encode_member has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def encode_member(member, out, is_union_member = false)
        case member.declaration
        when AST::Declarations::Void
          out.puts "return"
        end
                Severity: Minor
                Found in lib/xdrgen/generators/python.rb - About 1 hr to fix

                  Method build_type_field_types has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def build_type_field_types(node)
        types = Hash.new { |h, k| h[k] = [] }
        ingest_node = lambda do |n|
          n.definitions.each{ |nn| ingest_node.call(nn) } if n.respond_to?(:definitions)
          n.nested_definitions.each{ |nn| ingest_node.call(nn) } if n.respond_to?(:nested_definitions)
                  Severity: Minor
                  Found in lib/xdrgen/generators/rust.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method type_string has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def type_string(type)
        case type
        when AST::Typespecs::Bool
          "bool"
        when AST::Typespecs::Double
                  Severity: Minor
                  Found in lib/xdrgen/generators/python.rb - About 1 hr to fix

                    Method reference has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          def reference(parent, type)
        base_ref = base_reference type

        parent_name = name(parent) if parent
        cyclic = is_type_in_type_field_types(base_ref, parent_name)
                    Severity: Minor
                    Found in lib/xdrgen/generators/rust.rb - About 1 hr to fix

                      Method render_element has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                            def render_element(defn, imports, element, post_name="implements XdrElement")
        path = element.name.camelize + ".java"
        name = name_string element.name
        out  = @output.open(path)
        render_top_matter out
                      Severity: Minor
                      Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                              def render_definition(out, defn)
        render_nested_definitions(out, defn)
        render_source_comment(out, defn)

        case defn
                        Severity: Major
                        Found in lib/xdrgen/generators/elixir.rb and 1 other location - About 1 hr to fix
                        lib/xdrgen/generators/javascript.rb on lines 27..44

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 52.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                              def render_definition(out, defn)
        render_nested_definitions(out, defn)
        render_source_comment(out, defn)

        case defn
                        Severity: Major
                        Found in lib/xdrgen/generators/javascript.rb and 1 other location - About 1 hr to fix
                        lib/xdrgen/generators/elixir.rb on lines 27..44

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 52.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method render_union_decode_from_interface has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              def render_union_decode_from_interface(out, union)
        name = name(union)
        out.puts "// DecodeFrom decodes this value using the Decoder."
        out.puts "func (u *#{name}) DecodeFrom(d *xdr.Decoder, maxDepth uint) (int, error) {"
        out.puts "  if maxDepth == 0 {"
                        Severity: Minor
                        Found in lib/xdrgen/generators/go.rb - About 1 hr to fix

                          Method render_typedef_decode_from_interface has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                def render_typedef_decode_from_interface(out, typedef)
        name = name(typedef)
        type = typedef.declaration.type
        out.puts "// DecodeFrom decodes this value using the Decoder."
        out.puts "func (s *#{name}) DecodeFrom(d *xdr.Decoder, maxDepth uint) (int, error) {"
                          Severity: Minor
                          Found in lib/xdrgen/generators/go.rb - About 1 hr to fix

                            Method type_string has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                  def type_string(type)
        case type
        when AST::Typespecs::Int ;
          "Integer"
        when AST::Typespecs::UnsignedInt ;
                            Severity: Minor
                            Found in lib/xdrgen/generators/java.rb - About 1 hr to fix

                              Method decode_type has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                    def decode_type(decl)
        case decl.type
        when AST::Typespecs::Int
          "Integer.unpack(unpacker)"
        when AST::Typespecs::UnsignedInt
                              Severity: Minor
                              Found in lib/xdrgen/generators/python.rb - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language